Page MenuHomeFreeBSD

Document opt_CMAKE_BOOL and opt_CMAKE_BOOL_OFF.
ClosedPublic

Authored by mat on Jun 26 2016, 10:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 8, 10:31 AM
Unknown Object (File)
Wed, May 8, 10:31 AM
Unknown Object (File)
Wed, May 8, 8:47 AM
Unknown Object (File)
Wed, May 8, 8:46 AM
Unknown Object (File)
Mar 18 2024, 6:18 PM
Unknown Object (File)
Feb 25 2024, 3:06 AM
Unknown Object (File)
Jan 16 2024, 6:33 AM
Unknown Object (File)
Jan 16 2024, 6:33 AM
Subscribers
None

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mat retitled this revision from to Document opt_CMAKE_BOOL and opt_CMAKE_BOOL_OFF..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
mat added a reviewer: wblock.
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
4360 ↗(On Diff #17890)

If/then sentence, so try to reword to avoid the halting pause after the if condition:

See <xref linkend="options-cmake_bool"/> for a shorter helper
when the value is boolean.
4370 ↗(On Diff #17890)

This sentence is kind of hard to parse (shown without markup):
"When option OPT_CMAKE_BOOL_OFF is selected, for each entry in OPT_CMAKE_BOOL then
-Dentry:BOOL=true is appended to CMAKE_ARGS."

"Selected" is also a little unclear. Maybe "used" or "specified". For the rest of the sentence:

When option OPT_CMAKE_BOOL_OFF is used, an
-Dentry:BOOL=true is appended to CMAKE_ARGS
for each entry in OPT_CMAKE_BOOL.
4376 ↗(On Diff #17890)

Again, kind of a confusing sentence, partly due to "selected", partly due to "option OPT".

4381 ↗(On Diff #17890)

"works in the same way but reversed" is kind of the text equivalent of a "not". Better to say "...is the opposite, "

mat marked 2 inline comments as done.Jun 26 2016, 4:31 PM
mat added inline comments.
en_US.ISO8859-1/books/porters-handbook/makefiles/chapter.xml
4370 ↗(On Diff #17890)

"selected" is the verb used in for all the options helpers in this chapter, and it is the right one, when the user builds a port, if there are options, he is presented with an option dialog where he selects the options he wants.

wblock edited edge metadata.

Thank you.

This revision is now accepted and ready to land.Jun 27 2016, 11:51 PM
This revision was automatically updated to reflect the committed changes.