Page MenuHomeFreeBSD

multimedia/mpv: Update to 0.18.0
ClosedPublic

Authored by cpm on Jun 25 2016, 10:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 20, 7:55 AM
Unknown Object (File)
Sat, May 16, 4:24 AM
Unknown Object (File)
Fri, May 8, 9:13 AM
Unknown Object (File)
Fri, May 8, 5:27 AM
Unknown Object (File)
Wed, May 6, 6:27 AM
Unknown Object (File)
Sun, May 3, 7:58 PM
Unknown Object (File)
Sat, May 2, 7:06 AM
Unknown Object (File)
Sat, May 2, 7:06 AM
Subscribers
None

Details

Summary
  • Update to 0.18.0 release
  • Update waf to 1.9.0pre3 release
  • Remove unneeded patches (applied upstream)
  • Fix CONFIGURE_ARGS adding/disabling certain features
  • Add patches to fix "-Wmissing-braces" warning, so the compiler is happy
  • Switch to USES=localbase framework
  • Bump library version in pkg-plist

Changelog:

https://github.com/mpv-player/mpv/releases/tag/v0.18.0
Test Plan

Need Q/A tests

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

cpm retitled this revision from to multimedia/mpv: Update to 0.18.0.
cpm updated this object.
cpm edited the test plan for this revision. (Show Details)
cpm added reviewers: AMDmi3, junovitch, feld.
junovitch edited edge metadata.

Approved but I would just recommend clarifying this in the commit message:

  • Fix "-Wmissing-braces" warning, so the compiler is happy

to

  • Add patches to fix "-Wmissing-braces" warning, so the compiler is happy
  • Fix pkg-plist

to

  • Bump library version in pkg-plist

The logic is the -Wmissing-braces is you adding the patches and not changing compiler flags to ignore it. The pkg-plist isn't really a "fix" per-say so just say your are bumping the library version to go with the port update.

This revision is now accepted and ready to land.Jun 26 2016, 12:49 PM

Approved but I would just recommend clarifying this in the commit message:

  • Fix "-Wmissing-braces" warning, so the compiler is happy

to

  • Add patches to fix "-Wmissing-braces" warning, so the compiler is happy
  • Fix pkg-plist

to

  • Bump library version in pkg-plist

The logic is the -Wmissing-braces is you adding the patches and not changing compiler flags to ignore it. The pkg-plist isn't really a "fix" per-say so just say your are bumping the library version to go with the port update.

Understood!

cpm edited edge metadata.
# poudriere testport -j 93x32 -o multimedia/mpv [OK]
# poudriere testport -j 93x64  -o multimedia/mpv [OK]
# poudriere testport -j 103x32 -o multimedia/mpv [OK]
# poudriere testport -j 103x64 -o multimedia/mpv [OK]
# poudriere testport -j current -o multimedia/mpv [OK]
This revision was automatically updated to reflect the committed changes.