Page MenuHomeFreeBSD

Fix multimedia/zoneminder build on head and 9.3-i386
ClosedPublic

Authored by olivier on Jun 15 2016, 8:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 3, 4:27 PM
Unknown Object (File)
Sat, Nov 30, 6:37 PM
Unknown Object (File)
Nov 25 2024, 12:17 PM
Unknown Object (File)
Nov 24 2024, 5:47 AM
Unknown Object (File)
Nov 23 2024, 7:48 PM
Unknown Object (File)
Nov 22 2024, 7:10 PM
Unknown Object (File)
Nov 22 2024, 5:09 PM
Unknown Object (File)
Nov 20 2024, 8:52 AM
Subscribers
None

Details

Summary

PR 210261
Because it "Build fixes which cause a package to become compilable where it was previously failing", there is no PORTREVISION increment.
Poudriere testport Q/A include some warning but seems false warning (more detail in the PR exchange).

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olivier retitled this revision from to Fix multimedia/zoneminder build on head and 9.3-i386.
olivier updated this object.
olivier edited the test plan for this revision. (Show Details)
olivier added reviewers: jadawin, tabthorpe.

No need of PORTREVISION ?

No need of PORTREVISION ?

This is how I interpret this patch: This patch fix build on some arch/revision. This mean building of this port previously failed on these arch/revision.
And in chapter "5.2.2.1. PORTREVISION" of the porter's handbook, on the examples of changes which do not require a PORTREVISION bump, we found this point:

  • Build fixes which cause a package to become compilable where it was previously failing

This is why I think we didn't need PORTREVISION on this specific case.

jadawin edited edge metadata.
This revision is now accepted and ready to land.Jun 20 2016, 7:51 AM
This revision was automatically updated to reflect the committed changes.