Page MenuHomeFreeBSD
Differential D6824

[iwm] Use mbuf for large firmware commands, like OpenBSD does.
ClosedPublic
Actions

Authored by imre_vdsz.com on Jun 12 2016, 1:10 PM.
Tags
None
Referenced Files
F156507078: D6824.id.diff
Thu, May 14, 5:55 AM
Unknown Object (File)
Wed, May 6, 10:55 PM
Unknown Object (File)
Wed, May 6, 1:45 AM
Unknown Object (File)
Fri, May 1, 11:16 AM
Unknown Object (File)
Thu, Apr 30, 7:20 PM
Unknown Object (File)
Mon, Apr 27, 11:06 AM
Unknown Object (File)
Sat, Apr 25, 6:48 AM
Unknown Object (File)
Thu, Apr 23, 11:10 AM
View All Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rS302104: [iwm] Use mbuf for large firmware commands, like OpenBSD does.
Summary
  • We also need to consider the size of large firmware commands in iwm_alloc_tx_ring(), in the dma tag creation, when qid == IWM_MVM_CMD_QUEUE. The old code apparently only allocated a 2KB (MCLBYTES) sized buffer when it actually expected 4KB.

Obtained from: DragonFlyBSD 65b2e1ba01c1ac9098eebea118d71cbc78eac25a

Test Plan

Tested on Intel AC 7260.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imre_vdsz.com updated this revision to Diff 17536.Jun 12 2016, 1:10 PM
imre_vdsz.com retitled this revision from to [iwm] Use mbuf for large firmware commands, like OpenBSD does..
imre_vdsz.com updated this object.
imre_vdsz.com edited the test plan for this revision. (Show Details)
imre_vdsz.com added a reviewer: adrian.
Herald added a subscriber: imp. · View Herald TranscriptJun 12 2016, 1:10 PM
adrian accepted this revision.Jun 22 2016, 4:38 PM
adrian edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2016, 4:38 PM
Closed by commit rS302104: [iwm] Use mbuf for large firmware commands, like OpenBSD does. (authored by adrian). · Explain WhyJun 23 2016, 1:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
iwm/
15 lines
43 lines

Diff 17786

View Options

head/sys/dev/iwm/if_iwm.c

Loading...
View Options

head/sys/dev/iwm/if_iwm_util.c

Loading...