Page MenuHomeFreeBSD
Differential D6819

[iwm] Add and use iwm_phy_db_free(), to plug phy_db memory leak.
ClosedPublic
Actions

Authored by imre_vdsz.com on Jun 11 2016, 9:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 8, 8:52 AM
Unknown Object (File)
Jan 23 2025, 1:30 PM
Unknown Object (File)
Jan 9 2025, 4:35 AM
Unknown Object (File)
Dec 25 2024, 10:32 PM
Unknown Object (File)
Nov 28 2024, 5:04 AM
Unknown Object (File)
Nov 28 2024, 5:01 AM
Unknown Object (File)
Nov 22 2024, 7:29 AM
Unknown Object (File)
Nov 22 2024, 7:29 AM
View All 70 Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rS302103: [iwm] Add and use iwm_phy_db_free(), to plug phy_db memory leak.
Summary
  • (Together with other iwm(4) memory leak fixes) Memory leakage in M_DEVBUF is now at ca. 2KB for each iwm(4) module load/unload cycle.

Obtained from: DragonFlyBSD eaf551a1d464c643e98ce5781971dd32124e9af1

Test Plan

Tested with AC 7260 wlan chipset

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imre_vdsz.com updated this revision to Diff 17528.Jun 11 2016, 9:11 PM
imre_vdsz.com retitled this revision from to [iwm] Add and use iwm_phy_db_free(), to plug phy_db memory leak..
imre_vdsz.com updated this object.
imre_vdsz.com edited the test plan for this revision. (Show Details)
imre_vdsz.com added a reviewer: adrian.
Herald added a subscriber: imp. · View Herald TranscriptJun 11 2016, 9:11 PM
adrian accepted this revision.Jun 22 2016, 4:37 PM
adrian edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2016, 4:37 PM
Closed by commit rS302103: [iwm] Add and use iwm_phy_db_free(), to plug phy_db memory leak. (authored by adrian). · Explain WhyJun 23 2016, 1:12 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
iwm/
2 lines
1 line
30 lines

Diff 17785

View Options

head/sys/dev/iwm/if_iwm.c

Show First 20 Lines • Show All 3,185 Lines • ▼ Show 20 Lines TAILQ_FOREACH(ifp, &V_ifnet, if_link) {
IF_ADDR_RLOCK(ifp); IF_ADDR_RLOCK(ifp);
TAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link) { TAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link) {
struct sockaddr *sa = ifa->ifa_addr; struct sockaddr *sa = ifa->ifa_addr;
if (prison_if(curthread->td_ucred, sa) != 0) if (prison_if(curthread->td_ucred, sa) != 0)
continue; continue;
addrs++; addrs++;
if (sa->sa_len <= sizeof(*sa)) { if (sa->sa_len <= sizeof(*sa)) {
ifr.ifr_addr = *sa; if (sa->sa_len < sizeof(*sa)) {
memset(&ifr.ifr_ifru.ifru_addr, 0,
sizeof(ifr.ifr_ifru.ifru_addr));
memcpy(&ifr.ifr_ifru.ifru_addr, sa,
sa->sa_len);
} else
ifr.ifr_ifru.ifru_addr = *sa;
sbuf_bcat(sb, &ifr, sizeof(ifr)); sbuf_bcat(sb, &ifr, sizeof(ifr));
max_len += sizeof(ifr); max_len += sizeof(ifr);
} else { } else {
sbuf_bcat(sb, &ifr, sbuf_bcat(sb, &ifr,
offsetof(struct ifreq, ifr_addr)); offsetof(struct ifreq, ifr_addr));
max_len += offsetof(struct ifreq, ifr_addr); max_len += offsetof(struct ifreq, ifr_addr);
sbuf_bcat(sb, sa, sa->sa_len); sbuf_bcat(sb, sa, sa->sa_len);
max_len += sa->sa_len; max_len += sa->sa_len;
▲ Show 20 Lines • Show All 1,195 Lines • Show Last 20 Lines
View Options

head/sys/dev/iwm/if_iwm_phy_db.h

Show First 20 Lines • Show All 3,185 Lines • ▼ Show 20 Lines TAILQ_FOREACH(ifp, &V_ifnet, if_link) {
IF_ADDR_RLOCK(ifp); IF_ADDR_RLOCK(ifp);
TAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link) { TAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link) {
struct sockaddr *sa = ifa->ifa_addr; struct sockaddr *sa = ifa->ifa_addr;
if (prison_if(curthread->td_ucred, sa) != 0) if (prison_if(curthread->td_ucred, sa) != 0)
continue; continue;
addrs++; addrs++;
if (sa->sa_len <= sizeof(*sa)) { if (sa->sa_len <= sizeof(*sa)) {
ifr.ifr_addr = *sa; if (sa->sa_len < sizeof(*sa)) {
memset(&ifr.ifr_ifru.ifru_addr, 0,
sizeof(ifr.ifr_ifru.ifru_addr));
memcpy(&ifr.ifr_ifru.ifru_addr, sa,
sa->sa_len);
} else
ifr.ifr_ifru.ifru_addr = *sa;
sbuf_bcat(sb, &ifr, sizeof(ifr)); sbuf_bcat(sb, &ifr, sizeof(ifr));
max_len += sizeof(ifr); max_len += sizeof(ifr);
} else { } else {
sbuf_bcat(sb, &ifr, sbuf_bcat(sb, &ifr,
offsetof(struct ifreq, ifr_addr)); offsetof(struct ifreq, ifr_addr));
max_len += offsetof(struct ifreq, ifr_addr); max_len += offsetof(struct ifreq, ifr_addr);
sbuf_bcat(sb, sa, sa->sa_len); sbuf_bcat(sb, sa, sa->sa_len);
max_len += sa->sa_len; max_len += sa->sa_len;
▲ Show 20 Lines • Show All 1,195 Lines • Show Last 20 Lines
View Options

head/sys/dev/iwm/if_iwm_phy_db.c

Show First 20 Lines • Show All 3,185 Lines • ▼ Show 20 Lines TAILQ_FOREACH(ifp, &V_ifnet, if_link) {
IF_ADDR_RLOCK(ifp); IF_ADDR_RLOCK(ifp);
TAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link) { TAILQ_FOREACH(ifa, &ifp->if_addrhead, ifa_link) {
struct sockaddr *sa = ifa->ifa_addr; struct sockaddr *sa = ifa->ifa_addr;
if (prison_if(curthread->td_ucred, sa) != 0) if (prison_if(curthread->td_ucred, sa) != 0)
continue; continue;
addrs++; addrs++;
if (sa->sa_len <= sizeof(*sa)) { if (sa->sa_len <= sizeof(*sa)) {
ifr.ifr_addr = *sa; if (sa->sa_len < sizeof(*sa)) {
memset(&ifr.ifr_ifru.ifru_addr, 0,
sizeof(ifr.ifr_ifru.ifru_addr));
memcpy(&ifr.ifr_ifru.ifru_addr, sa,
sa->sa_len);
} else
ifr.ifr_ifru.ifru_addr = *sa;
sbuf_bcat(sb, &ifr, sizeof(ifr)); sbuf_bcat(sb, &ifr, sizeof(ifr));
max_len += sizeof(ifr); max_len += sizeof(ifr);
} else { } else {
sbuf_bcat(sb, &ifr, sbuf_bcat(sb, &ifr,
offsetof(struct ifreq, ifr_addr)); offsetof(struct ifreq, ifr_addr));
max_len += offsetof(struct ifreq, ifr_addr); max_len += offsetof(struct ifreq, ifr_addr);
sbuf_bcat(sb, sa, sa->sa_len); sbuf_bcat(sb, sa, sa->sa_len);
max_len += sa->sa_len; max_len += sa->sa_len;
▲ Show 20 Lines • Show All 1,195 Lines • Show Last 20 Lines