Page MenuHomeFreeBSD

[iwm] Fix iwm_dma_contig_free(). dma->map is always NULL here.
ClosedPublic

Authored by imre_vdsz.com on Jun 11 2016, 9:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 16 2025, 5:37 AM
Unknown Object (File)
Jan 10 2025, 12:13 PM
Unknown Object (File)
Nov 22 2024, 7:29 AM
Unknown Object (File)
Nov 22 2024, 7:29 AM
Unknown Object (File)
Nov 22 2024, 7:09 AM
Unknown Object (File)
Oct 16 2024, 11:33 PM
Unknown Object (File)
Sep 24 2024, 4:43 AM
Unknown Object (File)
Sep 16 2024, 1:57 PM
Subscribers

Details

Reviewers
adrian
Summary
  • When bus_dmamem_alloc is used, the bus_dmamap_t is usually set to NULL, so we were never actually freeing any dma memory allocations done via iwm_dma_contig_alloc(). So we should check dma->vaddr instead of dma->map here.
  • Also, the dmamap is actually supposed to be invalidated as part of bus_dmamem_free(), so bus_dmamap_destroy() is never needed here.

Obtained from: DragonFlyBSD ef2b29a7ba6ca8a9d2c82ab591c0622227ff84cb

Test Plan

Tested on AC 7260, loaded and unloaded the iwm module several times, with
some wlan usage each time.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4193
Build 4236: arc lint + arc unit

Event Timeline

imre_vdsz.com retitled this revision from to [iwm] Fix iwm_dma_contig_free(). dma->map is always NULL here..
imre_vdsz.com updated this object.
imre_vdsz.com edited the test plan for this revision. (Show Details)
imre_vdsz.com added a reviewer: adrian.
adrian edited edge metadata.
This revision is now accepted and ready to land.Jun 22 2016, 4:37 PM