ic_macaddr when vap != NULL.
ClosedPublic
Actions

Authored by imre_vdsz.com on Jun 7 2016, 12:17 AM.

Details

Reviewers

avos
adrian

Commits

rS302101: [iwm] Use vap->iv_myaddr instead of ic->ic_macaddr when vap != NULL.

Summary

ic_macaddr is only used for the initial mac address provided by NVM. We should rather use vap->iv_myaddr when vap != NULL, to allow the MAC address to be changed later with ifconfig(8).

Obtained from: DragonFlyBSD 4aee7a78275676d22d14c04177bd0c9377d91478

Test Plan

Tested with Intel AC 7260, but didn't verify yet whether the MAC address
can be specified with ifconfig(8) after this change.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imre_vdsz.com updated this revision to Diff 17371.Jun 7 2016, 12:17 AM

imre_vdsz.com retitled this revision from to [iwm] Use vap->iv_myaddr instead of ic->ic_macaddr when vap != NULL..

imre_vdsz.com updated this object.

imre_vdsz.com edited the test plan for this revision. (Show Details)

imre_vdsz.com added a reviewer: adrian.

Herald added a subscriber: imp. · View Herald TranscriptJun 7 2016, 12:17 AM

Andrity, is this okay to use as the MAC?

Sure (ic_macaddr is device's MAC and iv_myaddr may be a) a copy of it b) user-specified via 'ifconfig wlan0 create wlandev <dev> wlanaddr <addr>' c) user-specified via 'ifconfig wlan0 ether <addr>')

This revision is now accepted and ready to land.Jun 22 2016, 4:28 PM

P.S. I'm not sure that this code will be called when vap == NULL ...

Closed by commit rS302101: [iwm] Use vap->iv_myaddr instead of ic->ic_macaddr when vap != NULL. (authored by adrian). · Explain WhyJun 23 2016, 12:57 AM

This revision was automatically updated to reflect the committed changes.