Allow to define NOSRC on release.conf
ClosedPublic
Actions

Authored by garga on Jun 3 2016, 5:59 PM.

Details

Reviewers

Commits

rS301280: One of the already implemented options in release/Makefile is NOSRC. When

Summary

One of the already implemented options in release/Makefile is NOSRC. When it's
defined, installation image is shipped without source distribution (src.txz)

Add the hability of defining NOSRC in release.conf and pass it to 'make release'
argument

Sponsored by: Rubicon Communications (Netgate)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

garga updated this revision to Diff 17276.Jun 3 2016, 5:59 PM

garga retitled this revision from to Allow to define NOSRC on release.conf.

garga updated this object.

garga edited the test plan for this revision. (Show Details)

garga added a reviewer: gjb.

Herald added a subscriber: imp. · View Herald TranscriptJun 3 2016, 5:59 PM

I'm fine with this overall, however we should avoid combining the DOCPORTS option into this.

The NODOC and NOPORTS are orthogonal to NOSRC intentionally, since if NOPORTS is set, NODOC must be set (since it relies on the ports/ tree).

They are not combined, DOCPORTS is just a variable that will contain all selected knobs to pass to make release call. It's populated based on each (NOPORTS, NOSRC or NODOC) value

The logic you mentioned, about set NODOC when NOPORTS is set happens inside release/Makefile and it's not affected by this change