Page MenuHomeFreeBSD

Add an X11 option to java/openjdk[78].
ClosedPublic

Authored by asomers on Jun 2 2016, 10:09 PM.

Details

Summary

java/openjdk7/Makefile
java/openjdk8/Makefile
Make X11 a default-on option. When off, some dependencies disappear
and some lib depends turn into build depends.

Test Plan

I built each port with and without the X11 option. In between builds, I
deinstalled all the X dependencies.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers updated this revision to Diff 17247.Jun 2 2016, 10:09 PM
asomers retitled this revision from to Add an X11 option to java/openjdk[78]..
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: brd.

@brd Greg hasn't responded for almost 6 months. I declare a maintainer timeout, but I still need your approval to commit it. Poudriere builds completed successfully for all combinations of 9.3/10.3/11.0 jail, openjdk7/openjdk8, and X11 off/on.

brd accepted this revision.Dec 9 2016, 8:19 PM
brd edited edge metadata.

Go for it!

This revision is now accepted and ready to land.Dec 9 2016, 8:19 PM
This revision was automatically updated to reflect the committed changes.

Not sure how yet, but this breaks the build for openjdk8.
Reverted only the openjdk8 part (git checkout 4ad18c2 -- java/openjdk8) and it builds again.

I see testing is only done using poudriere and as a leaf build, so the culprit is likely to be in reverse dependency. The port I'm trying to build is databases/sqlworkbench. X11 option is set to ON.

Have tried with MAKE_JOBS_UNFSAFE (and setting --jobs-number=1 to CONFIGURE_ARGS) with no help. Log{F757339} attached.

@m.r.sopacua_gmail.com I can't reproduce your failure. Can you please retry with a fully up-to-date ports tree? If it still fails, send me your complete poudriere log, and tell me how you created your poudriere jail.

I'm not using poudriere.

What I'm doing in a setting with no ports installed is:
/usr/bin/env LOCALBASE=/usr/local CCACHE_DIR=/var/cache/ccache/devstation PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin make PACKAGES=/var/packages/devstation -DUSE_PACKAGE_DEPENDS -C /usr/ports/databases/sql-workbench clean stage

/etc/make.conf:

VALID_CATEGORIES=       maintainer
WRKDIRPREFIX=/usr/obj/ports
DISTDIR=/var/distfiles
DEFAULT_VERSIONS=       pgsql=9.5 python=3.5 mysql=5.6 php=5.6 \
                        ssl=openssl-devel bdb=5 linux=c7 perl=5.24
USE_LOCAL_MK=yes
WITH_CCACHE_BUILD=yes
CCACHE_DIR?=/var/cache/ccache/root
OPTIONS_UNSET=  DEBUG NLS EXAMPLES
games_wesnoth_OPTIONS_SET=      NLS
MAKE_JOBS_NUMBER=       8

Ports tree was up-to-date when I reported.

@m.r.sopacua_gmail.com if you aren't using Poudriere, then what base system are you using? What do freebsd-version and uname -a show? Are you sure you cleaned openjdk8's workdir before you updated the ports tree?