xen-netfront: perform an interface reset when changing options
ClosedPublic
Actions

Authored by royger on May 31 2016, 12:18 PM.

Details

Reviewers

Commits

rS301201: xen-netfront: perform an interface reset when changing options

Summary

The PV backend will only pick the new options when the interface is detached
and reattached again, so perform a full reset when changing options. This is
very fast, and should not be noticeable by the user.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

royger updated this revision to Diff 17148.May 31 2016, 12:18 PM

royger retitled this revision from to xen-netfront: perform an interface reset when changing options.

royger updated this object.

royger edited the test plan for this revision. (Show Details)

royger added a reviewer: liuw_liuw.name.

Herald added a subscriber: imp. · View Herald TranscriptMay 31 2016, 12:18 PM

Can't comment on the feature flags to freebsd flags mapping.

Overall this reconnection approach looks sensible to me. The good thing is that is doesn't require any additional extension for the protocol so we can always switch to something better in the future,

Closed by commit rS301201: xen-netfront: perform an interface reset when changing options (authored by royger). · Explain WhyJun 2 2016, 11:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

xen/

netfront/

netfront.c

128 lines

Diff 17221

View Options

head/sys/dev/xen/netfront/netfront.c

xen-netfront: perform an interface reset when changing optionsClosedPublicActions