Page MenuHomeFreeBSD

[plist] igor -Ry and some other rewording and fixes.

Authored by mat on Aug 20 2014, 3:06 PM.

Diff Detail

rD FreeBSD doc repository
Lint Skipped
Unit Tests Skipped

Event Timeline

mat updated this revision to Diff 1172.Aug 20 2014, 3:06 PM
mat retitled this revision from to [plist] igor -Ry and some other rewording and fixes..
mat updated this object.
mat edited the test plan for this revision. (Show Details)
wblock added a subscriber: wblock.Aug 30 2014, 7:46 PM
wblock added inline comments.
25 ↗(On Diff #1216)

"for" can probably be removed without harm.

45 ↗(On Diff #1216)

Remove "that".

46 ↗(On Diff #1216)

"Something like" is vague. Like it how?

54 ↗(On Diff #1216)

up in <filename>pkg-plist</filename>. When

55 ↗(On Diff #1216)

the port is upgraded, it will not be necessary to edit dozens (or in some

57 ↗(On Diff #1216)


59 ↗(On Diff #1216)

<para>If files are installed conditionally on the options

115 ↗(On Diff #1216)

Break sentence after "enough".

142 ↗(On Diff #1216)

s/need to/must/

191 ↗(On Diff #1216)

s/the files carefully/files that have been carefully/

198 ↗(On Diff #1216)

This is a little vague. @sample does all the work, all the porter has to do is use it. Maybe this is clearer with the sentence split into two:

Instead, install sample files with a <filename><replaceable>filename</replaceable>.sample</filename> extension. The <literal>@sample</literal> macro automates this. For each sample file, add a line to <filename>pkg-plist</filename>:</para>

Would be nice to explain that if the actual file is not present, the sample file will be wirtten to it. Also, on uninstall, config files that have been edited by the user will not be deleted, or overwritten by the sample file when reinstalled.

284 ↗(On Diff #1216)

Break sentence after "used".

mat updated this revision to Diff 1545.Sep 11 2014, 2:11 PM

Back with changes

Thanks for your patience!

174 ↗(On Diff #1545)

s/need to be/must/

175 ↗(On Diff #1545)

Break sentence at "if":

" created. If they are not created by the port code, create them in the Makefile:"

181 ↗(On Diff #1545)

"Then" is not needed.

mat closed this revision.Sep 16 2014, 12:44 PM
mat updated this revision to Diff 1642.

Closed by commit rD45619 (authored by @mat).