Page MenuHomeFreeBSD

Tools/scripts/rmport: update for Bugzilla and usability improvements
ClosedPublic

Authored by rene on May 16 2016, 4:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 27, 5:46 PM
Unknown Object (File)
Sat, Apr 27, 5:09 PM
Unknown Object (File)
Nov 30 2023, 2:28 AM
Unknown Object (File)
Oct 17 2023, 2:39 PM
Unknown Object (File)
Oct 17 2023, 2:39 PM
Unknown Object (File)
Oct 17 2023, 2:37 PM
Unknown Object (File)
Oct 17 2023, 2:37 PM
Unknown Object (File)
Oct 17 2023, 2:37 PM
Subscribers
None

Details

Summary

Tweak the Tools/scripts/rmport script to:
-look for bug reports on Bugzilla (needs pretty-printing)

  • allow for PORTSDIR to be a symbolic link
  • forcibly remove tmp/rmport.XXXXX/ports so that the tmp/rmprt.XXXXXX/ports/.svn directory is deleted without asking the user
Test Plan

Tested with net/isc-dhcp41-server (net/omcmd has a dependency on it), net/samba36 (has active PRs in Bugzilla) and lang/bf2c (no PRs or reverse dependencies)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rene retitled this revision from to Tools/scripts/rmport: update for Bugzilla and usability improvements.
rene updated this object.
rene edited the test plan for this revision. (Show Details)
rene added a reviewer: crees.
rene set the repository for this revision to rP FreeBSD ports repository.

Also allow PORTSDIR to be a symbolic link when using the -a option.

Perhaps the script should also check Phabricator for patches when looking for PRs on Bugzilla?

Prevent a false positive in check_dep_core() if the port name on the command line ends with a slash, e.g., lang/bf2c/

crees edited edge metadata.

Looks great-- I've put in an improvement for the PR check, but thanks for the rest, great work.

Tools/scripts/rmport
234 ↗(On Diff #16397)

Try this regex-- it works well for me:

  1. Strip out the HTML, find PR# and synopsis, print

    printf "%s" "${raw}" \ |sed -ne 's,^:space:*.a href="show_bug.cgi?id=\([0-9][0-9]*\)".\([^0-9][^<]*\).*,\1: \2,p' \ |sort
This revision is now accepted and ready to land.May 16 2016, 7:17 PM
This revision was automatically updated to reflect the committed changes.