Add bsearch_b to the libc map and the stdlib header.
ClosedPublic
Actions

Authored by pfg on Aug 19 2014, 7:33 PM.

Details

Reviewers

theraven
pfg

Summary

bsearch_b is the Apple blocks enabled version of bsearch(3).
This was added to libc in Revision 264042 but the commit
missed the declaration required to make use of it.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

pfg updated this revision to Diff 1156.Aug 19 2014, 7:33 PM

pfg retitled this revision from to Add bsearch_b to the libc map and the stdlib header..

pfg updated this object.

pfg edited the test plan for this revision. (Show Details)

pfg added a reviewer: theraven.

Shouldn't all of these BLOCKS declarations be moved down to the main BSD_VISIBLE block, since they are non-standard interfaces?

In D638#3, @wollman wrote:

Shouldn't all of these BLOCKS declarations be moved down to the main BSD_VISIBLE block, since they are non-standard interfaces?

Yes, I think that is reasonable.

They were proposed as N1451, and have become popular but they are not standard.

Updating D638: Add bsearch_b to the libc map and the stdlib header. #

As suggested by Garrett Wollman, move the block declarations
to the BSD_VISIBLE section.

...
Sending include/stdlib.h
Sending lib/libc/stdlib/Symbol.map
Transmitting file data ..
Committed revision 270952.

Special Thanks to wollman for the review!

This revision is now accepted and ready to land.Sep 1 2014, 10:27 PM

This was committed (long ago) as r270952.
Thanks!

Revision Contents
Changeset List

Path

Size

include/

stdlib.h

14 lines

lib/

libc/

stdlib/

Symbol.map

1 line

Diff 1249

View Options

include/stdlib.h