Page MenuHomeFreeBSD

Limit Options.inc generation to desired targets
ClosedPublic

Authored by emaste on May 4 2016, 8:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 30, 9:06 AM
Unknown Object (File)
Fri, Jun 28, 9:57 AM
Unknown Object (File)
Apr 25 2024, 11:38 PM
Unknown Object (File)
Apr 25 2024, 11:33 PM
Unknown Object (File)
Mar 21 2024, 6:38 AM
Unknown Object (File)
Mar 21 2024, 6:38 AM
Unknown Object (File)
Mar 21 2024, 6:38 AM
Unknown Object (File)
Dec 21 2023, 10:37 AM
Subscribers
None

Details

Summary

As mentioned in the Makefile there's an atrocious hack to generate a different version of Options.inc.h, depending on the library being built. Remove the catch-all else case and limit it to the two specific libraries, so that we don't accidentally use the Options.inc.h from clangdriver if a future libary also uses Options.inc.h.

Test Plan

make tinderbox

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste retitled this revision from to Limit Options.inc generation to desired targets.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
emaste added a reviewer: dim.

Add clangfrontend and clangfrontendtool, they also use the same Options.inc as clangdriver.

dim edited edge metadata.

Yes, this is a very good safety belt.

This revision is now accepted and ready to land.May 5 2016, 12:35 PM
emaste edited edge metadata.

Also build Options.inc.h for usr.bin/clang/clang

This revision now requires review to proceed.May 5 2016, 3:29 PM
This revision was automatically updated to reflect the committed changes.