A PF_UNIX MSG_PEEK receive copied the SCM_RIGHTS control to userland without
externalizing it, so the mbuf's internal file pointers were exposed. Skip the
control on MSG_PEEK; it is delivered normally on a non-peek receive.
Details
Details
Diff Detail
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
glebius, this addresses the XXXGL MSG_PEEK control note: instead of copying the
un-externalized control out, I skip it on peek. Does this approach work for you,
or would you prefer a different one (e.g. externalize on peek)?
Comment Actions
There's a PR open for this already, which includes a test case: https://github.com/freebsd/freebsd-src/pull/2469
I made a comment there a little while ago, I'd prefer to keep discussion there.
Comment Actions
Duplicate of https://github.com/freebsd/freebsd-src/pull/2469 (same fix, with a test case). Keeping discussion there per markj@. Abandoning.
Comment Actions
Ok, migrating to github, given there is a history there and today PHP had a bad day :) In general, using reviews.freebsd.org is preferred over github.