tests/truss: xfail accepted ABIs test if linux(4) not implemented
ClosedPublic
Actions

Authored by siva on Fri, Sep 11, 5:02 PM.

Details

Reviewers

dteske

Commits

Summary

Split accepted ABIs test into separate case and conditionally
xfail it on archs that don't have linux(4) support.

This fixes a CI test failure[0].

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

siva requested review of this revision.Fri, Sep 11, 5:02 PM

Thanks for splitting this out of unknown_syscall, and for using uname -p. One suggested edit on the Linux names.

usr.bin/truss/tests/truss_test.sh
268	warning is correct but skip like require_truss

This revision now requires changes to proceed.Sun, Sep 13, 3:16 AM

usr.bin/truss/tests/truss_test.sh
267–269	This is what I meant to suggest

usr.bin/truss/tests/truss_test.sh
267–269	I like the rest of the suggestion, but I'd argue that `atf_expect_fail` is more correct here. Since "sysdecode has no Linux ABI names on $arch", I would "expect this testcase to fail". In the future when sysdecode gets support for this, the test should pass again rather than continue to be skipped. We should take action in the future to correct this conditional skip once the support is ready.