Differential D59538

lib/googletest: also use -O0 for internal tests with GCC
ClosedPublic
Actions

Authored by siva on Wed, Sep 9, 4:46 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 6, 1:07 AM

	Unknown Object (File)
	Mon, Oct 5, 6:05 AM

	Unknown Object (File)
	Thu, Oct 1, 8:04 PM

	Unknown Object (File)
	Thu, Oct 1, 9:33 AM

	Unknown Object (File)
	Wed, Sep 30, 7:52 PM

	Unknown Object (File)
	Wed, Sep 30, 4:56 PM

	Unknown Object (File)
	Tue, Sep 29, 2:12 AM

	Unknown Object (File)
	Sat, Sep 26, 12:12 AM

View All 44 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG73d67bc5545b: lib/googletest: also use -O0 for internal tests with GCC
rGcf509d830547: lib/googletest: also use -O0 for internal tests with GCC
rG243bdaff7585: lib/googletest: also use -O0 for internal tests with GCC

Summary

This fixes the build with gcc 16's aggressive inlining.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

siva created this revision.Wed, Sep 9, 4:46 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Sep 9, 4:47 PM

siva requested review of this revision.Wed, Sep 9, 4:47 PM

Harbormaster completed remote builds in B76705: Diff 186284.Wed, Sep 9, 4:47 PM

It would be good for me to look at providing some feedback upstream. I'll add this to my TODO list for when I get fully online next week.

This revision is now accepted and ready to land.Sat, Sep 12, 1:36 AM

Closed by commit rG243bdaff7585: lib/googletest: also use -O0 for internal tests with GCC (authored by siva). · Explain WhySat, Sep 12, 6:30 PM

This revision was automatically updated to reflect the committed changes.

siva added a commit: rG243bdaff7585: lib/googletest: also use -O0 for internal tests with GCC.

siva added a commit: rGcf509d830547: lib/googletest: also use -O0 for internal tests with GCC.Mon, Sep 14, 2:22 PM

siva added a commit: rG73d67bc5545b: lib/googletest: also use -O0 for internal tests with GCC.Mon, Sep 14, 2:48 PM

Revision Contents
Changeset List

Path

Size

lib/

googletest/

tests/

6 lines

Diff 186533

lib/googletest/tests/Makefile.inc

Loading...