Page MenuHomeFreeBSD

sysutils/sylve: Update to 0.3.0
ClosedPublic

Authored by hayzam_gmail.com on Mon, Aug 24, 7:24 PM.
Tags
None
Referenced Files
F171369810: D59159.diff
Thu, Sep 10, 5:59 PM
F171351046: D59159.diff
Thu, Sep 10, 3:00 PM
F171351027: D59159.diff
Thu, Sep 10, 3:00 PM
F171329064: D59159.id.diff
Thu, Sep 10, 11:14 AM
F171326113: D59159.id184936.diff
Thu, Sep 10, 10:43 AM
F171316018: D59159.id.diff
Thu, Sep 10, 8:52 AM
F171305245: D59159.id.diff
Thu, Sep 10, 7:08 AM
Unknown Object (File)
Thu, Sep 10, 4:29 AM
Subscribers
None

Details

Summary

Changelog: https://github.com/AlchemillaHQ/Sylve/releases/tag/v0.3.0

Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hayzam_gmail.com created this revision.
hayzam_gmail.com retitled this revision from sysutils/sylve: update to 0.3.0 to sysutils/sylve: Update to 0.3.0.Mon, Aug 24, 8:40 PM
sysutils/sylve/Makefile
5–6

Optional nit: You can use ${DISTVERSIONFULL}.

39–41

This is pre-existing and optional, but it looks like go.mk already extracts sylve-web-assets.tar.gz into ${WRKDIR}/web-files, so it's getting extracted twice. If you wanted to save on one extraction, you could do something like this:

post-extract:
	@${RM} -r ${WRKSRC}/internal/assets/web-files
	@${MV} ${WRKDIR}/web-files ${WRKSRC}/internal/assets/

The ${RM} is because the module includes internal/assets/web-files/.gitignore, so the directory already exists.

sysutils/sylve/files/pkg-message.in
4–5

Most of the information dropped from the old pkg-message.in is covered under https://sylve.io/docs/, so pointing there seems fine. One thing I don't see covered in the docs, though, is the note about the default username. Should that be added somewhere?

The note about changing the password used to point out that it should be changed before starting the service for the first time. If a user starts the service and then changes the password, could they be exposed while running with the username/password admin/admin?

Since pkg-message.in is for install only, users upgrading from 0.2.3_x to 0.3.0 won't see the message. Also, users who installed any earlier version wouldn't have seen the message either because SUB_FILES was missing. You could add { type: upgrade, maximum_version: "0.3.0" } if you want to cover this likely common case.

This revision is now accepted and ready to land.Tue, Aug 25, 5:49 PM
This revision was automatically updated to reflect the committed changes.