Page MenuHomeFreeBSD
Differential D590

Stage one of multipass suspend/resume
ClosedPublic
Actions

Authored by jhibbits on Aug 12 2014, 12:34 AM.
Tags
None
Referenced Files
F176547985: D590.diff
Mon, Oct 19, 6:13 PM
Unknown Object (File)
Fri, Oct 2, 9:46 PM
Unknown Object (File)
Tue, Sep 29, 3:18 PM
Unknown Object (File)
Tue, Sep 29, 2:51 PM
Unknown Object (File)
Tue, Sep 29, 2:41 PM
Unknown Object (File)
Tue, Sep 29, 11:10 AM
Unknown Object (File)
Tue, Sep 29, 6:10 AM
Unknown Object (File)
Tue, Sep 29, 4:52 AM
View All Files
Subscribers
None

Details

Reviewers
jhb
Commits
rS272013: Stage one of multipass suspend/resume
Summary

Add the beginnings of multipass suspend/resume, by introducing
BUS_SUSPEND_CHILD/BUS_RESUME_CHILD, and move the PCI driver to this.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jhibbits updated this revision to Diff 1054.Aug 12 2014, 12:34 AM
jhibbits retitled this revision from to Stage one of multipass suspend/resume.
jhibbits updated this object.
jhibbits edited the test plan for this revision. (Show Details)
jhibbits added a reviewer: jhb.
jhibbits updated this revision to Diff 1059.Aug 12 2014, 6:04 AM

Fix a copy&paste-o. Default for BUS_RESUME_CHILD should be bus_generic_resume_child, not suspend.

jhibbits updated this revision to Diff 1076.Aug 12 2014, 4:54 PM

BASEPERIPH doesn't need to be resumed early. This was a hack, but is not necessary.

jhb added inline comments.Sep 20 2014, 1:43 PM
sys/dev/pci/pci.c
3667 ↗(On Diff #1076)

Looks like this can just go away and be replaced in the method list with bus_generic_suspend now?

jhibbits added a comment.Sep 20 2014, 5:33 PM

Thanks for the review!

sys/dev/pci/pci.c
3667 ↗(On Diff #1076)

It can. I kept it in case there was anything else that needed done as well. But, if that's not the case, I'll just remove it.

jhibbits updated this revision to Diff 1696.Sep 20 2014, 5:49 PM

Remove pci_suspend(), as it's no longer necessary, given it only calls
bus_generic_suspend().

jhb accepted this revision.Sep 22 2014, 3:44 PM
jhb edited edge metadata.

I think this is good to go.

This revision is now accepted and ready to land.Sep 22 2014, 3:44 PM
jhibbits closed this revision.Sep 23 2014, 2:56 AM
jhibbits updated this revision to Diff 1722.

Closed by commit rS272013 (authored by @jhibbits).

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
pci/
93 lines
3 lines
kern/
22 lines
40 lines
sys/
2 lines

Diff 1722

View Options

head/sys/dev/pci/pci.c

Loading...
View Options

head/sys/dev/pci/pci_private.h

Loading...
View Options

head/sys/kern/bus_if.m

Loading...
View Options

head/sys/kern/subr_bus.c

Loading...
View Options

head/sys/sys/bus.h

Loading...