Page MenuHomeFreeBSD

lang/rust: unbreak build on gcc platforms
ClosedPublic

Authored by jbeich on Apr 10 2016, 1:51 AM.
Tags
None
Referenced Files
F132288860: D5897.id15277.diff
Wed, Oct 15, 1:41 PM
F132242750: D5897.diff
Wed, Oct 15, 3:10 AM
Unknown Object (File)
Sat, Oct 11, 8:58 AM
Unknown Object (File)
Mon, Oct 6, 8:08 PM
Unknown Object (File)
Mon, Oct 6, 1:12 PM
Unknown Object (File)
Sat, Oct 4, 5:22 PM
Unknown Object (File)
Sat, Oct 4, 4:40 PM
Unknown Object (File)
Sat, Oct 4, 1:29 PM
Subscribers

Details

Summary

GCC isn't default on all platforms FreeBSD supports, and some users may have defined FAVORITE_COMPILER=gcc via make.conf(5) or Makefile.local.

$ make
[...]
g++5: error: unrecognized command line option '-stdlib=libc++'
Test Plan
$ make -V CONFIGURE_ARGS CHOSEN_COMPILER_TYPE=""
--disable-valgrind --disable-docs    --mandir=/usr/local/man  --release-channel=stable

$ make -V CONFIGURE_ARGS CHOSEN_COMPILER_TYPE=gcc
--disable-valgrind --disable-docs    --mandir=/usr/local/man  --release-channel=stable

$ make -V CONFIGURE_ARGS CHOSEN_COMPILER_TYPE=clang
--disable-valgrind --disable-docs  --enable-clang  --mandir=/usr/local/man  --release-channel=stable

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jbeich retitled this revision from to lang/rust: unbreak build on gcc platforms.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added a reviewer: riggs.
riggs edited edge metadata.

I am testing an update to rust 1.8.0 at the moment.
@jbeich if you want, you can commit this right away (could you use / instead of @ inside the variable modifier to match the rest of the port?), otherwise I'll include it when I am happy with the 1.8.0 update, hopefully tomorrow morning

This revision is now accepted and ready to land.Apr 16 2016, 8:19 PM
This revision was automatically updated to reflect the committed changes.