Page MenuHomeFreeBSD
Differential D58848

devel/py-pyyaml: Convert build to use PEP 517
Needs ReviewPublic
Actions

Authored by michaelo on Fri, Aug 14, 10:09 PM.

Details

Reviewers
vishwin
mandree
diizzy
Group Reviewers
Python

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75605
Build 72488: arc lint + arc unit

Event Timeline

michaelo requested review of this revision.Fri, Aug 14, 10:09 PM
michaelo created this revision.
Harbormaster completed remote builds in B75595: Diff 184077.Fri, Aug 14, 10:09 PM
michaelo added a reviewer: Python.Fri, Aug 14, 10:09 PM
vishwin requested changes to this revision.Fri, Aug 14, 10:36 PM
vishwin added inline comments.
devel/py-pyyaml/Makefile
42

Under no circumstances is this to be overridden. The framework does not even have this ability and one will never be added.

When setuptools is updated past 70.1, ie D46236, it will be normalised to all lowercase anyway. For now, patch setup.py.

44

This whole block is excessive.

This revision now requires changes to proceed.Fri, Aug 14, 10:36 PM
michaelo updated this revision to Diff 184089.Sat, Aug 15, 8:38 AM

Address comments and lowercase wheel name in setup.py

Harbormaster completed remote builds in B75605: Diff 184089.Sat, Aug 15, 8:39 AM
michaelo marked 2 inline comments as done.Sat, Aug 15, 8:39 AM

Changes applied.

Revision Contents
Changeset List

PathSize
devel/
py-pyyaml/
18 lines
files/
10 lines

Diff 184089

View Options

devel/py-pyyaml/Makefile

Loading...
View Options

devel/py-pyyaml/files/patch-setup.py

Loading...