Page MenuHomeFreeBSD

ena: Swap cleanup order
ClosedPublic

Authored by akiyano_amazon.com on Tue, Jul 14, 9:46 PM.
Tags
None
Referenced Files
F163638118: D58239.diff
Sat, Jul 25, 2:02 AM
Unknown Object (File)
Thu, Jul 23, 8:31 AM
Unknown Object (File)
Thu, Jul 23, 5:15 AM
Unknown Object (File)
Tue, Jul 21, 11:42 PM
Unknown Object (File)
Mon, Jul 20, 10:34 PM
Unknown Object (File)
Sun, Jul 19, 3:25 AM
Unknown Object (File)
Sun, Jul 19, 1:24 AM
Unknown Object (File)
Sat, Jul 18, 5:32 AM
Subscribers

Details

Summary

As RX processing is heavier than TX completions processing, swap the
order and process TX completions first, in order to avoid starving the
completions and causing potential missing TX completions.

Submitted by: Ofir Tabachnik <ofirt@amazon.com>
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

akiyano_amazon.com planned changes to this revision.
akiyano_amazon.com created this revision.

I'm not convinced by the rationale here -- it seems to me that the stronger argument is "processing tx completions frees up space on the tx ring, which we might want when we respond to packets which we received". But the change itself seems reasonable.

This revision is now accepted and ready to land.Wed, Jul 15, 2:57 AM
This revision was automatically updated to reflect the committed changes.