Page MenuHomeFreeBSD

sysutils/rpi-usbboot: Raspberry Pi USB device provisioning tool
Needs ReviewPublic

Authored by jrm on Thu, May 28, 10:31 PM.

Details

Reviewers
emaste

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73535
Build 70418: arc lint + arc unit

Event Timeline

jrm requested review of this revision.Thu, May 28, 10:31 PM
jrm created this revision.

Add an rpi- prefix for the package name

Would it make sense for it to be sysutils/rpi-usbboot as well, so the port and package name match? I'm not sure about conventions here.

We could, and there are advantages to having the portname match the directory. For example, when you have the package installed and, based on the package name, search the ports tree for rpi-usboot, you'll get a hit.

The downsides are:

  • The port won't match the upstream name, so we'll have to override some default values to get things to work. Actually, just setting GH_PROJECT will do.
  • There are some arguments against having a hyphen in the port name. It is/was a parsing convention that portlint still warns about (WARN: Makefile: using hyphen in PORTNAME. consider using PKGNAMEPREFIX and/or PKGNAMESUFFIX.) Package names take the form ${PKGNAMEPREFIX}${PORTNAME}${PKGNAMESUFFIX}-${PKGVERSION}, where the last hyphen separates the name from the version. If PORTNAME itself contains a hyphen, any (old) tools that assume there are no hyphens in ${PORTNAME} could fail. That said, there are a lot of ports that have a hyphen in their name, so any tool out in the wild that assumes this is going to run into a lot of problems.

I'll make that change.

Rename the port to rpi-usbboot

jrm retitled this revision from sysutils/usbboot: Raspberry Pi USB device boot and provisioning tool to sysutils/rpi-usbboot: Raspberry Pi USB device boot and provisioning tool.Fri, May 29, 1:12 AM
jrm retitled this revision from sysutils/rpi-usbboot: Raspberry Pi USB device boot and provisioning tool to sysutils/rpi-usbboot: Raspberry Pi USB device provisioning tool.Fri, May 29, 1:15 AM

Base the port on the HEAD of upstream's repository, which includes some helpful fixes since the last tag. Upstream is using date-base tags, so just using lastest commit and calling it 20260527 should be fine.