Page MenuHomeFreeBSD

New port -- databases/pg_citus
ClosedPublic

Authored by matthew on Mar 24 2016, 5:50 PM.

Details

Reviewers
None
Commits
rP411931: What is Citus?

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

matthew updated this revision to Diff 14581.Mar 24 2016, 5:50 PM
matthew retitled this revision from to New port -- databases/pg_citus.
matthew updated this object.
matthew edited the test plan for this revision. (Show Details)
mat added inline comments.Mar 24 2016, 8:13 PM
databases/pg_citus/Makefile
16 ↗(On Diff #14581)

This should be DISTVERSIONPREFIX=v in the top block.

matthew updated this revision to Diff 14584.Mar 24 2016, 9:04 PM

Use DISTVERSIONPREFIX

matthew marked an inline comment as done.Mar 24 2016, 9:07 PM

Fixed, thanks.

Hmmm... seems to have failed for entirely different reasons on 9.3 and 10.1.

matthew updated this revision to Diff 14600.Mar 25 2016, 3:18 PM

FreeBSD < 10.0-RELEASE needs a BUILD_DEPENDS on textproc/flex

pi added a comment.Mar 25 2016, 4:52 PM

Builds on 9.3a now. 10.2i still open.

mat added inline comments.Mar 25 2016, 5:37 PM
databases/pg_citus/Makefile
8 ↗(On Diff #14600)

This should be between PORTVERSION and CATEGORIES. portlint should have told you that.

matthew updated this revision to Diff 14609.Mar 25 2016, 6:45 PM

Nove DISTVERSIONPREFIX to the correct location.

matthew marked an inline comment as done.Mar 25 2016, 6:45 PM
matthew updated this revision to Diff 14615.Mar 25 2016, 9:59 PM

Using both the INT64CONST() macro and suffixing a constant value with
'UL' breaks compilation on systems where HAVE_LL_CONSTANTS is defined
in ${LOCALBASE}/include/postgresql/server/pg_config.h (ie. i386
machines)

mat added a comment.Mar 25 2016, 10:15 PM

Note that your local setup seems to be adding svn:keywords=Author Date Id Rev URL to all the files, it'll need to be fixed before commit :-)

databases/pg_citus/Makefile
6 ↗(On Diff #14615)

there may be missing a <tab> here.

matthew updated this revision to Diff 14617.Mar 25 2016, 10:21 PM

Add missing tab character

matthew marked an inline comment as done.Mar 25 2016, 10:31 PM

Hmmm... I've now removed the svn:keywords bits from my subversion config. I used to use it for some projects long since migrated to git. Anyhow, I plan to use ${PORTSDIR}/Tools/scripts/addport to actually do the commit, so that wouldn't be a problem in any case.

This revision was automatically updated to reflect the committed changes.