Page MenuHomeFreeBSD

devel/libks: add new port
ClosedPublic

Authored by hayzam_gmail.com on Sat, May 9, 6:01 PM.
Tags
None
Referenced Files
F157097504: D56907.id177503.diff
Mon, May 18, 10:31 AM
F157085261: D56907.diff
Mon, May 18, 8:47 AM
Unknown Object (File)
Thu, May 14, 8:52 PM
Unknown Object (File)
Thu, May 14, 5:09 PM
Unknown Object (File)
Thu, May 14, 4:31 PM
Unknown Object (File)
Wed, May 13, 12:54 AM
Unknown Object (File)
Tue, May 12, 6:58 PM
Unknown Object (File)
Tue, May 12, 4:40 PM
Subscribers
None

Details

Summary

Add a new devel/libks port for SignalWire's libks support library.

libks provides common C utility code used by SignalWire and related projects, including platform abstraction, threading, networking, JSON, UUID, TLS, logging, buffers, and general helper routines.

The upstream repository is named libks, but the installed ABI and package metadata use the libks2 name. Upstream installs libks2.so, libks2 pkg-config metadata, CMake config files, headers under include/libks2, and documentation under share/doc/libks2.

This includes local FreeBSD compatibility patches for platform detection, UUID headers, and thread ID handling.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

hayzam_gmail.com created this revision.
hayzam_gmail.com added a reviewer: jrm.
hayzam_gmail.com edited the summary of this revision. (Show Details)
jrm requested changes to this revision.Mon, May 11, 8:21 PM

This mostly looks good, but a few issues need to be addressed:

  • You are missing an entry in devel/Makfile.
  • The code uses uuid_generate_random() and uuid_unparse(), which are supplied by the API provided by misc/libuuid. The base system's <uuid.h> doesn't have those functions. This means you should remove files/patch-src_include_libks_ks__types.h and files/patch-src_ks__json__check.c. The build failure after you remove those patches is fixed by adding localbase to USES.
devel/libks/Makefile
19

You can remove this.

25

Non-blocking nit: portclippy/portfmt suggests this belongs above DOCSDIR.

This revision now requires changes to proceed.Mon, May 11, 8:21 PM
  • Added libks to devel/Makefile
  • Remove UUID workaround patches; add localbase to USES based on @jrm's feedback

Looks good. I'll commit with some minor tweaks to the commit message to comply with the guidelines in the Committer's Guide, and to remove mention of the patches for the UUID includes. BTW, if you're not already using it, there is a commit template you can use by doing git config --add core.hooksPath .hooks. Look good to you?

commit c787f4531c5d697e2d4bfe7ffc1f6299afcb6f20 (HEAD -> gitarc-D56907)
Author:     hayzamjs <hayzam@gmail.com>
AuthorDate: 2026-05-11 19:00
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2026-05-11 19:16

    devel/libks: Add new port

    Add a new devel/libks port for SignalWire's libks support library.

    libks provides common C utility code used by SignalWire and related
    projects, including platform abstraction, threading, networking, JSON,
    UUID, TLS, logging, buffers, and general helper routines.

    The upstream repository is named libks, but the installed ABI and
    package metadata use the libks2 name. Upstream installs libks2.so,
    libks2 pkg-config metadata, CMake config files, headers under
    include/libks2, and documentation under share/doc/libks2.

    This includes local FreeBSD compatibility patches for platform detection
    and thread ID handling.

    Reviewed by:    jrm
    Differential Revision:  https://reviews.freebsd.org/D56907
This revision is now accepted and ready to land.Mon, May 11, 10:22 PM
In D56907#1304597, @jrm wrote:

Looks good. I'll commit with some minor tweaks to the commit message to comply with the guidelines in the Committer's Guide, and to remove mention of the patches for the UUID includes. BTW, if you're not already using it, there is a commit template you can use by doing git config --add core.hooksPath .hooks. Look good to you?

commit c787f4531c5d697e2d4bfe7ffc1f6299afcb6f20 (HEAD -> gitarc-D56907)
Author:     hayzamjs <hayzam@gmail.com>
AuthorDate: 2026-05-11 19:00
Commit:     Joseph Mingrone <jrm@FreeBSD.org>
CommitDate: 2026-05-11 19:16

    devel/libks: Add new port

    Add a new devel/libks port for SignalWire's libks support library.

    libks provides common C utility code used by SignalWire and related
    projects, including platform abstraction, threading, networking, JSON,
    UUID, TLS, logging, buffers, and general helper routines.

    The upstream repository is named libks, but the installed ABI and
    package metadata use the libks2 name. Upstream installs libks2.so,
    libks2 pkg-config metadata, CMake config files, headers under
    include/libks2, and documentation under share/doc/libks2.

    This includes local FreeBSD compatibility patches for platform detection
    and thread ID handling.

    Reviewed by:    jrm
    Differential Revision:  https://reviews.freebsd.org/D56907

That looks good, and thank you for the review + notes!

This revision was automatically updated to reflect the committed changes.