Differential D5645

kbdcontrol: add -P path option to add keymap search paths
ClosedPublic
Actions

Authored by emaste on Mar 15 2016, 2:46 PM.

Details

Reviewers

cem

Commits

rS296926: kbdcontrol: add -P path option to add keymap search paths

Summary

This will allow a cleaner implementation of rS296899

PR 193865
https://bugs.freebsd.org/193865

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 14338.Mar 15 2016, 2:46 PM

emaste retitled this revision from to kbdcontrol: add -P path option to add keymap search paths.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

LGTM.

usr.sbin/kbdcontrol/kbdcontrol.c
844–845 ↗	(On Diff #14338)	Can we rename 'fd' while we're here? :)

This revision is now accepted and ready to land.Mar 15 2016, 5:41 PM

fd -> file
allow -P to appear anywhere on the command line
only set up keymap paths once

This revision now requires review to proceed.Mar 16 2016, 1:21 AM

correct optind resetting

cem accepted this revision.Mar 16 2016, 1:59 AM

cem edited edge metadata.

This revision is now accepted and ready to land.Mar 16 2016, 1:59 AM

Closed by commit rS296926: kbdcontrol: add -P path option to add keymap search paths (authored by emaste). · Explain WhyMar 16 2016, 4:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

kbdcontrol/

kbdcontrol.1

9 lines

kbdcontrol.c

87 lines

Diff 14350

View Options

head/usr.sbin/kbdcontrol/kbdcontrol.1