Page MenuHomeFreeBSD
Differential D5645

kbdcontrol: add -P path option to add keymap search paths
ClosedPublic
Actions

Authored by emaste on Mar 15 2016, 2:46 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 11, 8:33 PM
Unknown Object (File)
Sun, Aug 9, 5:40 PM
Unknown Object (File)
Fri, Aug 7, 7:10 PM
Unknown Object (File)
Tue, Aug 4, 7:38 AM
Unknown Object (File)
Tue, Aug 4, 4:29 AM
Unknown Object (File)
Thu, Jul 30, 2:33 PM
Unknown Object (File)
Tue, Jul 28, 1:05 AM
Unknown Object (File)
Jul 14 2026, 10:37 PM
View All Files
Subscribers
cem

Details

Reviewers
cem
Commits
rS296926: kbdcontrol: add -P path option to add keymap search paths
Summary

This will allow a cleaner implementation of rS296899

PR 193865
https://bugs.freebsd.org/193865

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 14338.Mar 15 2016, 2:46 PM
emaste retitled this revision from to kbdcontrol: add -P path option to add keymap search paths.
emaste updated this object.
emaste edited the test plan for this revision. (Show Details)
cem accepted this revision.Mar 15 2016, 5:41 PM
cem added a reviewer: cem.
cem added a subscriber: cem.

LGTM.

usr.sbin/kbdcontrol/kbdcontrol.c
844–845 ↗(On Diff #14338)

Can we rename 'fd' while we're here? :)

This revision is now accepted and ready to land.Mar 15 2016, 5:41 PM
emaste updated this revision to Diff 14346.Mar 16 2016, 1:21 AM
emaste edited edge metadata.

fd -> file
allow -P to appear anywhere on the command line
only set up keymap paths once

This revision now requires review to proceed.Mar 16 2016, 1:21 AM
emaste updated this revision to Diff 14347.Mar 16 2016, 1:42 AM
emaste edited edge metadata.

correct optind resetting

cem accepted this revision.Mar 16 2016, 1:59 AM
cem edited edge metadata.
This revision is now accepted and ready to land.Mar 16 2016, 1:59 AM
Closed by commit rS296926: kbdcontrol: add -P path option to add keymap search paths (authored by emaste). · Explain WhyMar 16 2016, 4:05 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
usr.sbin/
kbdcontrol/
9 lines
87 lines

Diff 14350

View Options

head/usr.sbin/kbdcontrol/kbdcontrol.1

Loading...
View Options

head/usr.sbin/kbdcontrol/kbdcontrol.c

Loading...