Page MenuHomeFreeBSD

devel/gumbo: Update to 0.13.2
Needs ReviewPublic

Authored by dave_freedave.net on Thu, Apr 9, 5:46 PM.
Tags
None
Referenced Files
F152495635: D56334.diff
Wed, Apr 15, 8:07 AM
F152414281: D56334.diff
Tue, Apr 14, 7:56 PM
Unknown Object (File)
Tue, Apr 14, 12:38 PM
Unknown Object (File)
Fri, Apr 10, 1:22 AM
F151642387: gumbo-0.13.2.log
Thu, Apr 9, 5:46 PM
Subscribers

Details

Reviewers
bdrewery
Summary

0.13.1 switched to meson and 0.13.2 added fuzzing tests.
Neither altered ABI/API

I am interested in creating some language bindings to gumbo and wanted to make sure that the latest still works with FreeBSD. Since everything worked out, may as well make available.

Test Plan

make test succeeds

poudriere testport -j FreeBSD16 -p local devel/gumbo:

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

diizzy added inline comments.
devel/gumbo/Makefile
12–13

Tests should be built on demand

13
19–20

This is incorrect

19–20

Why?
Set WRKSRC correctly if needed

20

Likely unnecessary

address comments:

  • change BUILD_DEPENDS to TEST_DEPENDS for googletest>0:devel/googletest
  • add compiler:c++17-lang to USES
  • remvove INSTALL_TARGET (had no effect)
  • remove post-extract target, just adjust WRKSRC
  • add MESON_ARGS until upstream fixes gtest detection with note on how to test
  • remove post-install target (also no effect)