Page MenuHomeFreeBSD
Differential D55962

devel/ghpr: add missing `BUILD_DEPENDS`
ClosedPublic
Actions

Authored by ngie on Mar 19 2026, 5:38 PM.
Tags
None
Referenced Files
F154427077: D55962.diff
Tue, Apr 28, 11:45 AM
Unknown Object (File)
Tue, Apr 28, 7:24 AM
Unknown Object (File)
Mon, Apr 27, 4:57 PM
Unknown Object (File)
Mon, Apr 27, 2:17 PM
Unknown Object (File)
Mon, Apr 27, 12:58 PM
Unknown Object (File)
Mon, Apr 27, 1:49 AM
Unknown Object (File)
Fri, Apr 24, 1:55 PM
Unknown Object (File)
Sun, Apr 19, 4:13 PM
View All 35 Files
Subscribers
bms
Python

Details

Reviewers
imp
Commits
R11:15c5542e3e7a: devel/ghpr: add missing `BUILD_DEPENDS`
Summary

This change adds additional build dependencies accidentally missed in
the previous commit.

Although the devel/py-setuptools dependency is technically redundant in
light of devel/py-setuptools-scm, it's best to express all of the needed
dependencies in BUILD_DEPENDS.

Adjust PYTHON_USES to only permit 3.11+ given the change introduced in
the pyproject.toml file upstream, while here.

Reported by: poudriere
Pointyhat to: ngie
Fixes: 59337d86174 ("devel/ghpr: update to v3")

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ngie requested review of this revision.Mar 19 2026, 5:38 PM
ngie created this revision.
Harbormaster completed remote builds in B71544: Diff 173941.Mar 19 2026, 5:38 PM
ngie updated this revision to Diff 173942.Mar 19 2026, 5:40 PM

Adjust minimum required python version to 3.11 to match pyproject.toml

Harbormaster completed remote builds in B71545: Diff 173942.Mar 19 2026, 5:40 PM
ngie edited the summary of this revision. (Show Details)Mar 19 2026, 5:42 PM
ngie added a reviewer: imp.
ngie edited the summary of this revision. (Show Details)
ngie added a subscriber: Python.
ngie added a comment.Mar 21 2026, 3:36 AM

@imp : ping?

bms added a subscriber: bms.Mar 22 2026, 3:54 AM
ngie retitled this revision from devel/gphr: add missing `BUILD_DEPENDS` to devel/ghpr: add missing `BUILD_DEPENDS`.Mar 22 2026, 5:58 AM
imp accepted this revision.Mar 22 2026, 2:57 PM

why 3.11+?
Otherwise looks good to me.

This revision is now accepted and ready to land.Mar 22 2026, 2:57 PM
Closed by commit R11:15c5542e3e7a: devel/ghpr: add missing `BUILD_DEPENDS` (authored by ngie). · Explain WhyMar 22 2026, 3:59 PM
This revision was automatically updated to reflect the committed changes.
ngie added a commit: R11:15c5542e3e7a: devel/ghpr: add missing `BUILD_DEPENDS`.

Revision Contents
Changeset List

PathSize
devel/
ghpr/
5 lines

Diff 174117

View Options

devel/ghpr/Makefile

Loading...