Page MenuHomeFreeBSD

lang/jpm: Update to 1.2.0
ClosedPublic

Authored by dave_freedave.net on Fri, Feb 20, 12:40 PM.
Tags
None
Referenced Files
F146635466: D55396.diff
Wed, Mar 4, 7:30 AM
Unknown Object (File)
Mon, Mar 2, 10:39 PM
Unknown Object (File)
Fri, Feb 27, 4:42 AM
Unknown Object (File)
Thu, Feb 26, 1:52 PM
Unknown Object (File)
Thu, Feb 26, 9:59 AM
Unknown Object (File)
Thu, Feb 26, 3:46 AM
Unknown Object (File)
Thu, Feb 26, 2:18 AM
Unknown Object (File)
Wed, Feb 25, 5:13 PM
Subscribers

Details

Summary

Technically all that was needed was bumping the DISTVERSION, removing PORTREVISION, running make makesum, and adding a new file to pkg-plist.

But I wanted to have a way to quickly test, and both portlint -A and portclippy --strict Makefile had a few nits so I went ahead and addressed them.

Test Plan

I need an updated jpm(1) to build the latest spork (a popular janet library). While spork can be built without jpm(1) it does make for an easy test: verify jpm install works for spork which I have done.

Also added a do-test target and verified make test works.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dave_freedave.net created this revision.

Just ran poudriere testport -j FreeBSD15 -p local lang/jpm and could probably use NO_ARCH=yes like D54667.

===>   Building jpm-1.2.0
pkg-static: DEVELOPER_MODE: Notice: arch "FreeBSD:15:amd64" -- no architecture specific files found:
**** could this package use a wildcard architecture?

it works for me of FreeBSD 15.0 RELEASE

This revision is now accepted and ready to land.Wed, Feb 25, 7:22 AM
arrowd added inline comments.
lang/jpm/Makefile
32

This looks wrong. The file always contains "/usr/local" while LOCALBASE may be set to something else. In this case sed would replace nothing.

42

Same here. If something always creates "/usr/local/..." then using the LOCALBASE variable is wrong.

For reasons @arrowd pointed out changing LOCALBASE back to /usr/local. I incorrectly trusted portlint on those.

Also just removed from do-test to match do-install target.

This revision now requires review to proceed.Wed, Feb 25, 12:01 PM
This revision is now accepted and ready to land.Wed, Feb 25, 4:14 PM
This revision was automatically updated to reflect the committed changes.