speaker, clock: Replace Giant lock with fine-grained locking
AbandonedPublic
Actions

Authored by guest-seuros on Jan 10 2026, 10:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 6, 9:27 PM

	Unknown Object (File)
	Sun, Mar 1, 1:38 PM

	Unknown Object (File)
	Mon, Feb 23, 2:17 PM

	Unknown Object (File)
	Jan 29 2026, 2:32 PM

	Unknown Object (File)
	Jan 20 2026, 8:20 AM

	Unknown Object (File)
	Jan 19 2026, 9:31 PM

	Unknown Object (File)
	Jan 18 2026, 6:23 AM

	Unknown Object (File)
	Jan 16 2026, 6:57 AM

View All 14 Files

Subscribers

imp

Details

Reviewers: None

Summary

Add sx lock to the speaker driver to protect spkr_active and spkr_inbuf,
removing the D_NEEDGIANT flag. Add mtx_lock_spin protection for timer2_state
in clock.c timer_spkr_acquire/release functions.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69783
Build 66666: arc lint + arc unit

Event Timeline

guest-seuros requested review of this revision.Jan 10 2026, 10:38 AM

guest-seuros created this revision.

Harbormaster completed remote builds in B69783: Diff 169448.Jan 10 2026, 10:38 AM

guest-seuros abandoned this revision.Jan 10 2026, 11:17 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

speaker/

spkr.c

73 lines

x86/

isa/

clock.c

12 lines

Diff 169448

View Options

sys/dev/speaker/spkr.c