Page MenuHomeFreeBSD
Differential D5398

net80211: fix TIM cleanup
ClosedPublic
Actions

Authored by avos on Feb 22 2016, 11:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 20, 4:13 PM
Unknown Object (File)
Fri, Mar 20, 1:03 AM
Unknown Object (File)
Thu, Mar 19, 5:45 AM
Unknown Object (File)
Thu, Mar 19, 5:35 AM
Unknown Object (File)
Wed, Mar 18, 7:30 PM
Unknown Object (File)
Mon, Mar 16, 3:04 AM
Unknown Object (File)
Fri, Mar 13, 5:27 PM
Unknown Object (File)
Fri, Mar 13, 5:27 PM
View All 98 Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rS295932: net80211: fix TIM cleanup.
Summary

Remove duplicate 'ni->ni_associd = 0' assignment from ieee80211_node_leave(), since it breaks iv_set_tim() in ic->ic_node_cleanup() (associd is cleared right after this call).

TODO: data races?

Test Plan

Tested with RTL8188EU (HOSTAP mode) and WUSB54GC (STA mode, with powersaving enabled).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avos updated this revision to Diff 13619.Feb 22 2016, 11:39 PM
avos retitled this revision from to net80211: fix TIM cleanup.
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptFeb 22 2016, 11:39 PM
adrian accepted this revision.Feb 23 2016, 5:53 AM
adrian edited edge metadata.

hah, good catch!

This revision is now accepted and ready to land.Feb 23 2016, 5:53 AM
Closed by commit rS295932: net80211: fix TIM cleanup. (authored by avos). · Explain WhyFeb 23 2016, 9:12 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
net80211/
1 line

Diff 13661

View Options

head/sys/net80211/ieee80211_node.c

Loading...