Page MenuHomeFreeBSD

github: Update with better guidance on what's acceptable for src
ClosedPublic

Authored by imp on Jul 25 2025, 7:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 11, 3:53 PM
Unknown Object (File)
Sat, Oct 11, 3:53 PM
Unknown Object (File)
Sat, Oct 11, 3:53 PM
Unknown Object (File)
Sat, Oct 11, 3:53 PM
Unknown Object (File)
Sat, Oct 11, 7:24 AM
Unknown Object (File)
Thu, Oct 2, 7:24 PM
Unknown Object (File)
Sep 6 2025, 9:54 PM
Unknown Object (File)
Sep 6 2025, 6:14 AM
Subscribers

Details

Summary

Tighten and clarify the submission requirements:

  • No AI submissions
  • No trivial submissions: pull requests have to solve a real problem
  • We may timeout requests after a month
  • FreeBSD committers (all repos) are responible for merging their commits to the appropriate repo. github can be used to seek approval for such commits (eg a ports committer wants to make a src change).
  • Wordsmith a few things to make them clearer to people new to our jargon.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Jul 25 2025, 7:35 PM
imp created this revision.
emaste added inline comments.
CONTRIBUTING.md
36

I find the negative here somewhat confusing (not trivial). Maybe something like

  • The request is substantive in nature. We generally don't accept minor or cosmetic changes unless they are part of larger work in that area. Pull requests should solve a real, actual problem.
39

If feedback is requested and one month passes without a response we may close the pull request.

50

to me "introduce trailing white space" is clear enough but have no problem being extra-explicit

52

I'd say either Differential Revision or Differential review (i.e., Revision is the proper name that Phab uses, but it is just a review).

53

I think we need to clarify this with the in-progress core@ AI policy, and in particular be clear about what we mean by "using."

54

I'd drop "chatbot" from account, if you have a real account but are just cutting and pasting from an LLM it's your account that will be dropped.

78
imp marked 6 inline comments as done.Jul 25 2025, 8:16 PM

thanks for the suggestions, please let me know if I missed anything.

CONTRIBUTING.md
52

I thought to maybe make it more generic... wise or no?

This revision was not accepted when it landed; it landed in state Needs Review.Jul 25 2025, 10:25 PM
This revision was automatically updated to reflect the committed changes.