Page MenuHomeFreeBSD

kyua: Try harder to delete directories.
ClosedPublic

Authored by des on Jul 9 2025, 7:54 PM.
Tags
None
Referenced Files
F144372232: D51229.id158240.diff
Sun, Feb 8, 2:41 AM
F144368832: D51229.id158239.diff
Sun, Feb 8, 2:19 AM
F144354521: D51229.id158238.diff
Sun, Feb 8, 12:30 AM
Unknown Object (File)
Sat, Feb 7, 4:05 PM
Unknown Object (File)
Mon, Feb 2, 11:05 AM
Unknown Object (File)
Sun, Feb 1, 11:38 PM
Unknown Object (File)
Sun, Feb 1, 10:47 AM
Unknown Object (File)
Sat, Jan 31, 9:41 AM

Details

Summary

When recursing into a directory to delete it, start by chmod'ing it to
0700. This fixes an issue where kyua is able to run, but not debug, a
test case that creates unwriteable directories, because when debugging
it tries (and fails) to delete the directory after the test completes.

This includes a test case which I haven't been able to test since we
don't build or install kyua's own tests.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jul 9 2025, 7:54 PM
igoro added a subscriber: igoro.

LGTM. And I had a successful testing on my side.

This revision is now accepted and ready to land.Jul 9 2025, 8:26 PM
This revision was automatically updated to reflect the committed changes.