Page MenuHomeFreeBSD
Differential D51229

kyua: Try harder to delete directories.
ClosedPublic
Actions

Authored by des on Jul 9 2025, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Aug 2, 5:06 AM
Unknown Object (File)
Sun, Aug 2, 3:28 AM
Unknown Object (File)
Sun, Aug 2, 3:28 AM
Unknown Object (File)
Sun, Aug 2, 2:18 AM
Unknown Object (File)
Sat, Aug 1, 5:31 AM
Unknown Object (File)
Thu, Jul 30, 3:48 AM
Unknown Object (File)
Tue, Jul 28, 8:40 PM
Unknown Object (File)
Mon, Jul 27, 1:22 PM
View All Files
Subscribers
igoro
imp
patmaddox

Details

Reviewers
igoro
Group Reviewers
Klara
Commits
rG91a6bf215cb1: kyua: Try harder to delete directories.
rGa7b4e2e9d0ca: kyua: Try harder to delete directories.
rG9bf14f2a475e: kyua: Try harder to delete directories.
Summary

When recursing into a directory to delete it, start by chmod'ing it to
0700. This fixes an issue where kyua is able to run, but not debug, a
test case that creates unwriteable directories, because when debugging
it tries (and fails) to delete the directory after the test completes.

This includes a test case which I haven't been able to test since we
don't build or install kyua's own tests.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Jul 9 2025, 7:54 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 9 2025, 7:54 PM
des requested review of this revision.Jul 9 2025, 7:54 PM
Harbormaster completed remote builds in B65307: Diff 158235.Jul 9 2025, 7:54 PM
des updated this revision to Diff 158238.Jul 9 2025, 8:14 PM

fix test

Harbormaster completed remote builds in B65310: Diff 158238.Jul 9 2025, 8:14 PM
des updated this revision to Diff 158239.Jul 9 2025, 8:21 PM

tybo

Harbormaster completed remote builds in B65311: Diff 158239.Jul 9 2025, 8:21 PM
igoro accepted this revision.Jul 9 2025, 8:26 PM
igoro added a subscriber: igoro.

LGTM. And I had a successful testing on my side.

This revision is now accepted and ready to land.Jul 9 2025, 8:26 PM
Closed by commit rG9bf14f2a475e: kyua: Try harder to delete directories. (authored by des). · Explain WhyJul 9 2025, 8:29 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rG9bf14f2a475e: kyua: Try harder to delete directories..
patmaddox added a subscriber: patmaddox.Jul 10 2025, 12:48 AM
des added a commit: rGa7b4e2e9d0ca: kyua: Try harder to delete directories..Jul 24 2025, 1:02 PM
des added a commit: rG91a6bf215cb1: kyua: Try harder to delete directories..

Revision Contents
Changeset List

PathSize
contrib/
kyua/
utils/
fs/
2 lines
14 lines

Diff 158240

View Options

contrib/kyua/utils/fs/operations.cpp

Loading...
View Options

contrib/kyua/utils/fs/operations_test.cpp

Loading...