Page MenuHomeFreeBSD
Differential D50827

devel/aws-sdk-cpp: make PulseAudio dependency optional
Needs ReviewPublic
Actions

Authored by olgeni on Fri, Jun 13, 6:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 7, 3:52 AM
Unknown Object (File)
Sun, Jul 6, 2:01 PM
Unknown Object (File)
Sat, Jul 5, 4:53 AM
Unknown Object (File)
Thu, Jul 3, 8:06 AM
Unknown Object (File)
Wed, Jul 2, 7:26 AM
Unknown Object (File)
Tue, Jul 1, 6:16 PM
Unknown Object (File)
Tue, Jul 1, 11:04 AM
Unknown Object (File)
Mon, Jun 30, 8:47 PM
View All 11 Files
Subscribers
guest-patmaddox

Details

Reviewers
eduardo
Summary
  • Add PULSEAUDIO option (enabled by default) for text-to-speech audio output
  • Move libpulse.so dependency from mandatory to optional based on PULSEAUDIO option
  • Add patch to respect FORCE_NO_PULSE CMake flag to disable PulseAudio detection
  • Allows building without audio dependencies when text-to-speech audio output is not needed

I made this because I have server builds on poudriere with no pulseaudio and noticed it sneaking in :)

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 64861
Build 61744: arc lint + arc unit

Event Timeline

olgeni requested review of this revision.Fri, Jun 13, 6:13 AM
olgeni created this revision.
Harbormaster completed remote builds in B64840: Diff 156955.Fri, Jun 13, 6:13 AM
olgeni edited the summary of this revision. (Show Details)Fri, Jun 13, 6:14 AM
eduardo added a comment.Fri, Jun 13, 12:08 PM

Hello,

Is there an upstream PR open about this changes?

eduardo added a comment.Fri, Jun 13, 8:25 PM

Also, there is a open bugzilla PR: 287370
Can you link summary to it?

Cheers

guest-patmaddox added a subscriber: guest-patmaddox.Sat, Jun 14, 2:35 AM
olgeni updated this revision to Diff 157016.Sat, Jun 14, 9:22 AM

Bit better variable name.

Harbormaster completed remote builds in B64861: Diff 157016.Sat, Jun 14, 9:22 AM
olgeni added a comment.Sat, Jun 14, 9:24 AM
In D50827#1160217, @eduardo wrote:

Hello,

Is there an upstream PR open about this changes?

Not yet, let me give it a try and see if it flies.

Revision Contents
Changeset List

PathSize
devel/
aws-sdk-cpp/
10 lines
files/
15 lines

Diff 157016

View Options

devel/aws-sdk-cpp/Makefile

Loading...
View Options

devel/aws-sdk-cpp/files/patch-src_aws-cpp-sdk-text-to-speech_CMakeLists.txt

Loading...