Page MenuHomeFreeBSD

lang/clisp: Build with system compiler
ClosedPublic

Authored by jrm on Thu, May 1, 6:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 23, 11:56 AM
Unknown Object (File)
Tue, May 20, 3:15 PM
Unknown Object (File)
Mon, May 19, 5:00 AM
Unknown Object (File)
Mon, May 19, 5:00 AM
Unknown Object (File)
Mon, May 19, 5:00 AM
Unknown Object (File)
Mon, May 19, 5:00 AM
Unknown Object (File)
Mon, May 19, 5:00 AM
Unknown Object (File)
Fri, May 16, 10:25 PM
Subscribers
None

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm requested review of this revision.Thu, May 1, 6:32 PM
jrm created this revision.
gerald requested changes to this revision.Thu, May 1, 10:48 PM

Nice, thank you!

I made one specific comment re the LDFLAGS magic that predates your changes (this one and the ones in the last half year) and which I believe can be removed as well.

For the sake of completeness: Seeing how this now builds with clang, even should GCC be required for some reason yet unknown, -fpermissive should not be required any longer.

lang/clisp/Makefile
38–39

I believe these two can go as well. They were added with revision 511d74702f779

commit 511d74702f7790d4938c55a5b80a2b73f18297d0
Author: Piotr Kubaj <pkubaj@FreeBSD.org>
Date: Fri May 17 19:23:07 2019 +0000

lang/clisp: fix build with GCC-based architectures

Add -lthr to LDFLAGS on GCC architectures.

While here, also add USES=localbase:ldflags.

PR:             237524

and I do not think we have GCC architectures left.

Plus with you removing USES=compiler, $CHOSEN_COMPILER_TYPE won't be defined any longer, so these two lines become noops anyway?

This revision now requires changes to proceed.Thu, May 1, 10:48 PM

Address comments from gerald

jrm marked an inline comment as done.Fri, May 2, 1:20 AM
This revision is now accepted and ready to land.Fri, May 2, 7:24 AM
This revision was automatically updated to reflect the committed changes.