kern_kcov: replace vm_page_next() with iterator
ClosedPublic
Actions

Authored by dougm on Apr 18 2025, 4:03 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 8, 12:12 AM

	Unknown Object (File)
	Thu, Nov 6, 12:32 AM

	Unknown Object (File)
	Wed, Nov 5, 1:16 PM

	Unknown Object (File)
	Wed, Nov 5, 1:06 PM

	Unknown Object (File)
	Wed, Nov 5, 4:44 AM

	Unknown Object (File)
	Tue, Oct 28, 7:23 AM

	Unknown Object (File)
	Sun, Oct 26, 5:53 AM

	Unknown Object (File)
	Oct 18 2025, 3:50 AM

View All 38 Files

Subscribers

None

Details

Reviewers

kib

Summary

Use VM_RADIX_FORALL, and drop a use of vm_page_next(), in kcov_free().

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

dougm requested review of this revision.Apr 18 2025, 4:03 PM

dougm created this revision.

kib added inline comments.Apr 18 2025, 4:05 PM

sys/kern/kern_kcov.c
410	What is npages? Should it be &pages?

Pass an iterator pointer, not an iterator, as an argument to VM_FOR macros. Fix the iter argument used in kern_kcov.c.

I suggest to do it as two commits.

This revision is now accepted and ready to land.Apr 18 2025, 4:52 PM

Closed with:

commit 4568f5a286a212fcceaf9a9bb90eabc104829f49
Author: Doug Moore <dougm@FreeBSD.org>
Date: Fri Apr 18 12:18:00 2025 -0500

but without proper Differential Revision label.

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_kcov.c

9 lines

vm/

vm_radix.h

8 lines

Diff 153873

View Options

sys/kern/kern_kcov.c