Diff Detail
- Repository
- R9 FreeBSD doc repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 63568 Build 60452: arc lint + arc unit
Event Timeline
The two reports are approved, but ldwg needs to be modified to have one sentence per line.
The introduction is also approved, but it would be better to move it to its own Phabricator review. Moreover, we usually add a line telling the number of reports of the quarter (which we still do not know since we are still waiting for late reports...).
I have not reviewed the _index.adoc file yet: I am going to review it when we get all reports. However, please create a separate review for this file too.
In general, please try to open one review per commit: multiple commits for the same Phabricator reviews is messy.
As you know, for status reports I tend to create one different commit for each report, thus ideally each report should have its own Phabricator review. I can commit more reports at once (although usually I prefer not to), and indeed I will commit both reports you submit in the same commit, but I see the introduction as something conceptually different and I would rather commit it always separately. The _index.adoc file is even more special, as committing this file actually publishes the full status report, so this one really needs its own commit, and then its own Phabricator review.
If however submitting all files together works better with your workflow, you might prefer to open a pull request on GitHub: having multiple commits referencing the same GitHub pull request works fine.
website/content/en/status/report-2025-01-2025-03/ldwg.adoc | ||
---|---|---|
12 | ||
35 | ||
37 |
replacement through
- https://reviews.freebsd.org/D49912 - add framework-kmod
- https://reviews.freebsd.org/D49910 - add LDWG
- https://reviews.freebsd.org/D49909 - add intro
- https://reviews.freebsd.org/D49908 - add _index