Page MenuHomeFreeBSD

mpi3mr: Handle Insufficient Power Fault Code
ClosedPublic

Authored by chandrakanth.patil_broadcom.com on Apr 9 2025, 7:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 3, 9:42 AM
Unknown Object (File)
Mon, Nov 3, 8:11 AM
Unknown Object (File)
Mon, Nov 3, 6:52 AM
Unknown Object (File)
Mon, Nov 3, 2:02 AM
Unknown Object (File)
Sun, Nov 2, 3:24 PM
Unknown Object (File)
Sun, Nov 2, 2:26 PM
Unknown Object (File)
Sat, Nov 1, 1:34 AM
Unknown Object (File)
Oct 24 2025, 12:54 PM
Subscribers
None

Details

Summary

The driver now checks for insufficient power faults during the load
phase and immediately fails initialization instead of retrying.

Additionally, if an insufficient power fault is detected by the watchdog
after the controller is up, the controller is marked as unrecoverable
instead of triggering a reset.

This improves fault handling and avoids unnecessary recovery attempts
in low-power conditions.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

You may commit either way, but I'd prefer that the two strings are folded onto one line if that's possible.

sys/dev/mpi3mr/mpi3mr.c
2795

Might be better to have this string all on one line to make it easier to grep, though I know that's not universally done in this driver. I'd rather not introduce new ones and this is an area that srcmgr has highlighted to change in our style guide.

3191

Same as above.

This revision is now accepted and ready to land.Apr 11 2025, 2:18 PM
chandrakanth.patil_broadcom.com added inline comments.
sys/dev/mpi3mr/mpi3mr.c
2795

ok. Will take care in separate patch.

3191

Ok. Will take care in separate patch.