lang/crystal: update to 1.15.1

[dch]

Summary

Thanks @straight-shoota & @ysbaddaden for diagnosis & patches

PR: 276271
Sponsored by: SkunkWerks, GmbH

[diizzy]

lang/crystal/Makefile

10

Should be PATCHFILES= and please use \ for consistency
Remove comments and add those with URLs in commit message

24–25

Does it really need git?

39

Please undo this style change

41–45

Is it possible to move it to something more recent?

[diizzy]

Friendly reminder that maintainer timeout etc only applies to PRs ins bugzilla not Phab

[dch]

incorporate diizzy feedback where appropriate

[dch]

There are also PRs open for these, phab is simpler for review and a nicer patch mgmt workflow.

lang/crystal/Makefile

10

This style is extremely common across the tree,
see most of the clang ports, for example.

This is significantly easier to identify immediately while
updating the Makefile which github PR is attached, rather
than reviewing all previous commit messages.

What's the benefit of doing this differently?

e.g.

# devel/opencl-clang/Makefile
16:PATCHFILES+= 529a9188114b.patch:-p1 # https://github.com/intel/opencl-clang/pull/415
17:PATCHFILES+= 9f50367661bb.patch:-p1 # https://github.com/intel/opencl-clang/pull/419
18:PATCHFILES+= 5491ffa3fde5.patch:-p1 # https://github.com/intel/opencl-clang/pull/416
19:PATCHFILES+= 8102ee2f83c3.patch:-p1 # https://github.com/intel/opencl-clang/pull/439

If this is part of PHB I'm happy to adjust.

What do you mean by "\ for consistency"?
Consistency with what? All the URLS will need / here.

I'll add the URLS shortly.

24–25

Probably. I'm not the maintainer, so I'm making minimal
changes to make it work.

39

The port now passes portclippy & portfmt. I don't know
what USE_GNOME is breaking. Please be more specific -
what is the style change that I'm supposed to be undoing
here?

41–45

No.

[diizzy]

lang/crystal/Makefile

10

Very few ports use this approach and not a single example in Porters Handbook use this style

Reference(s):
https://docs.freebsd.org/en/books/porters-handbook/book/#porting-pkg-plist
https://docs.freebsd.org/en/books/porters-handbook/book/#slow-patch-extra
https://docs.freebsd.org/en/books/porters-handbook/book/#makefile-master_sites-github-multiple
...and so on

39

Porters Handbook states that they're tools to help

All examples in Porters Handbook either lists USE_GITHUB separately with additional variables which also makes it easier to read

109

Why are these being split into multiple lines?