Differential D49584

Correct CTLTYPE of SYSCTL_SBINTIME_MSEC etc
ClosedPublic
Actions

Authored by cperciva on Mar 31 2025, 4:13 AM.

Tags

None

Referenced Files

	F154549445: D49584.id152886.diff
	Tue, Apr 28, 9:29 PM

	F154546963: D49584.id152886.diff
	Tue, Apr 28, 9:25 PM

	Unknown Object (File)
	Tue, Apr 28, 5:09 PM

	Unknown Object (File)
	Tue, Apr 28, 5:05 PM

	Unknown Object (File)
	Mon, Apr 27, 11:46 PM

	Unknown Object (File)
	Mon, Apr 27, 1:49 PM

	Unknown Object (File)
	Mon, Apr 27, 11:27 AM

	Unknown Object (File)
	Wed, Apr 22, 9:02 PM

View All 65 Files

Subscribers

None

Details

Reviewers

Commits

rG1bd29261b9d0: Correct CTLTYPE of SYSCTL_SBINTIME_MSEC etc
rGe85aaed60eb0: Correct CTLTYPE of SYSCTL_SBINTIME_MSEC etc

Summary

These should be CTLTYPE_S64, not CTLTYPE_INT, since they handle 64-bit
values.

Fixes: 003ffd57fee1 ("Add sysctl_usec_to_sbintime [...]")
MFC after: 2 weeks
Sponsored by: Amazon

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

cperciva requested review of this revision.Mar 31 2025, 4:13 AM

cperciva created this revision.

Harbormaster completed remote builds in B63219: Diff 152886.Mar 31 2025, 4:13 AM

cperciva mentioned this in D49585: pci: Make PCIe Eject timeout configurable.Mar 31 2025, 4:14 AM

I have similar changes in my tree... Or it appears I do...

But this doesn't matter to iosched: the size here only determines the size of the time interval that can be specified. iosched specifies in the 1-3 digit microseconds, while the range is up to 25 seconds. And the msec one has days of range. It's a good change none-the-less, though.

This revision is now accepted and ready to land.Apr 2 2025, 3:48 PM

Closed by commit rGe85aaed60eb0: Correct CTLTYPE of SYSCTL_SBINTIME_MSEC etc (authored by cperciva). · Explain WhyApr 2 2025, 3:52 PM

This revision was automatically updated to reflect the committed changes.

cperciva added a commit: rGe85aaed60eb0: Correct CTLTYPE of SYSCTL_SBINTIME_MSEC etc.

cperciva added a commit: rG1bd29261b9d0: Correct CTLTYPE of SYSCTL_SBINTIME_MSEC etc.Apr 16 2025, 3:19 AM

Revision Contents
Changeset List

Path

Size

sys/

sys/

8 lines

Diff 153024

sys/sys/sysctl.h

Loading...