Details
- Reviewers
koobs
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| www/py-jwt/Makefile | ||
|---|---|---|
| 1 ↗ | (On Diff #842) | Upstream name is lowercase(PyJWT) [1], match in PORTNAME |
| 9 ↗ | (On Diff #842) | Missing LICENSE/LICENSE_FILE |
| 13 ↗ | (On Diff #842) | This upstream is good, since they set test_suite= in setup.py [1], which means python setup.py test command works out of the box to run tests. Add regression-test: build (1) https://github.com/progrium/pyjwt/blob/master/setup.py#L32 |
| www/py-jwt/files/patch-jwt__jws.py | ||
| 1 ↗ | (On Diff #842) | Send this upstream (github PR/issue) |
| www/py-jwt/files/patch-jwt__jwt.py | ||
| 1 ↗ | (On Diff #842) | Send this upstream (github PR/issue) |
| www/py-jwt/pkg-descr | ||
| 3 ↗ | (On Diff #842) | Homepage is normally set by authors in setup.py under the URL= entry [1]. Use it unless there's a better option. (1) https://github.com/progrium/pyjwt/blob/master/setup.py#L18 |
| 3 ↗ | (On Diff #842) | Missing WWW: ? |
Latest version. Notes:
No license set, I do not set them because I feel the license framework is a liability.
Although it claims to have tests, there are none, and trying to run them fails. Maybe this is not a problem.
| Makefile | ||
|---|---|---|
| 2 |
Note: You'll probably need to set DISTNAME to get distfiles/fetching done once PORTNAME is lowercased | |
| 10 | LICENSE and LICENSE_FILE please :) If not for the License Framework, then for Python Ports and Team. (because we care, together, as a team) Personally speaking, my own opinions and feelings about liability or effectiveness of a particular feature don't preclude me from participating or warrant standing-off on that basis alone. | |
| 12 | RSASSA-PKCS1-v1_5 signature support | |
| 18 | "=" is sufficient for option_*_DEPENDS | |
| www/py-pyjwt/Makefile | ||
|---|---|---|
| 11 ↗ | (On Diff #1282) | LICENSE=MIT (1) https://github.com/progrium/pyjwt/blob/master/setup.py#L24 FWIW, adding LICENSE information is metadata (if available), not an assertion. I do agree they should only be added if explicitly specified and unambiguous upstream |
| 13 ↗ | (On Diff #1282) | This override is not necessary anymore |
| 15 ↗ | (On Diff #1282) | s/-v1_5/ v1.5/ ? |
| 20 ↗ | (On Diff #1282) | I prefer *_DEPENDS to come before options (and iirc, portlint likes them earlier too), but this is a minor nit. |
| 23 ↗ | (On Diff #1282) | ${PYDISTUTILS_SETUP} is better than ${PYSETUP} in what will become the canonical test command invocation. It wraps the 'setup.py' string in a setuptools import, which adds the setuptools 'test' command to distutils only ports. |
| www/py-pyjwt/Makefile | ||
|---|---|---|
| 11 ↗ | (On Diff #1282) | Feel free to go ahead without it |
One minor change in RSASSA_DESC value, otherwise LGTM.
Dont forget:
- pkg-descr (no trailing slash on WWW: URL)
- Adding it to www/Makefile (under py-pyjwt)
Ship it!
| Makefile | ||
|---|---|---|
| 17 | RSASSA-PKCS1 v1.5 | |