Details
- Reviewers
koobs
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| www/annotator-store/Makefile | ||
|---|---|---|
| 14 | py-itsdangerous has a JSON option that defaults to off, but it might be needed for this port. No idea how to check for that. | |
| www/annotator-store/Makefile | ||
|---|---|---|
| 4 | Upstream name is 'annotator' [1] | |
| 6 | www python | |
| 7 | Remove this, use USE_GITHUB=yes and GH_* variables instead, which to DISTNAME,WRKSRC, etc for you (See: bsd.sites.mk) | |
| 8 | Not needed with USE_GITHUB/GH-*, see previous comment | |
| 16 | Match the versioning in setup.py for all RUN_DEPENDS entries as closely as possible unless they cannot be matched given the limitations in our make syntax. Of course, if a version requirement is ==, use >= instead https://github.com/openannotation/annotator-store/blob/master/setup.py#L4 | |
| 21 | Not needed with USE_GITHUB and GH-* variables, See earlier comment | |
| www/annotator-store/pkg-descr | ||
| 5 | Strip trailing slashes | |
| www/annotator-store/Makefile | ||
|---|---|---|
| 22 | I note [1] that Python 3.x support is experimental (and perhaps not in the release distribution?). Unless tested and functional, set USE_PYTHON=-2.7 | |
Update. Note that this really is a port for annotator-store, not annotator.js, so I think the portname is correct.
| www/annotator-store/Makefile | ||
|---|---|---|
| 3 | Our target state for all Python ports is that PORTNAME matches upstream PyPi name if it exists there. Exceptional cases may warrant otherwise, but this is not one of them. Among other reasons, Python developers and users expect to be able to "pip install <pypi-name>" and it is there default expectation to search under these names in packages/ports as well. Process being:
Bonus: It helps FreeBSD rank well for searches containing those terms | |
| 4 | annotator(-store) is now 0.14.1. Update to suit | |
| 13–14 | Lowercase no? Also, Flask is optional since Annotator (this port) 0.12.0 | |
| 15 | I don't think installing ElasticSearch server (and thus Java) should be done unconditionally, unless every annotator-store node must have a local elasticsearch instance locally. ES servers can be remote, and can be (and often are) clustered across multiple nodes. If not, something like: OPTIONS_DEFINE=ELASTICSEARCH ELASTICSEARCH_DESC=Include ElasticSearch Server on this host This is where Debians Suggests/Recommends offers some nice granularity to optional components. | |
| 22 | GH_COMMIT is now deprecated (See Mk/bsd.sites.mk) Alternatively, use MASTER_SITES=CHEESESHOP and remove GITHUB/GH_* bits | |
| 24 | USE_PYTHON has been replaced by USES=python[:versionspec] (See Uses/python.mk for more) Also, annotator-store (this port) apparently supports Python 3: | |
| 25–26 | This is now: USE_PYTHON= <feature>[,<feature] Again see Uses/python.mk for more detail | |
| www/annotator-store/pkg-descr | ||
| 3 | Strip trailing slash | |
I'm reconsidering whether this is the best storage plugin to port. ElasticSearch appears to be a big Java blob, and not necessary for small implementations.
Here is a list of alternates. Some are very nice, but mostly I would like one that is low on overhead, open licensed, and easy to port. Maybe the CouchDB one.
https://github.com/openannotation/annotator/wiki#backend-stores
The nodejs one is very nice, and has a live demo: http://ec2-54-191-181-65.us-west-2.compute.amazonaws.com:3060/annotation/mary/demo.html