Page MenuHomeFreeBSD

[PATCH] databases/py-sqlalchemy{14,20}: Add FLAVORS
AbandonedPublic

Authored by kiwi on Jan 22 2025, 3:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 19, 12:40 PM
Unknown Object (File)
Thu, Sep 18, 10:28 PM
Unknown Object (File)
Sep 14 2025, 12:56 AM
Unknown Object (File)
Sep 13 2025, 4:02 PM
Unknown Object (File)
Sep 10 2025, 7:57 AM
Unknown Object (File)
Aug 10 2025, 4:18 PM
Unknown Object (File)
Jul 16 2025, 1:36 AM
Unknown Object (File)
Jul 11 2025, 10:52 PM
Subscribers
None

Details

Reviewers
0mp
sunpoet
Summary
databases/py-sqlalchemy{14,20}: Add FLAVORS

Adding FLAVORS

Approved by: 0mp (mentor)
Test Plan

Built tested with all flavors on poudriere on 14.2 + python 3.11

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kiwi requested review of this revision.Jan 22 2025, 3:01 PM
kiwi created this revision.

Do I understand correctly that SQLITE is always enabled? Is that what we want?

Also, I think we might need a -sqllite flavor as well for completeness (which would be the same as the default flavor unfortunately). That's something to be discussed with the maintainer, however.

Otherwise, the patch looks OK. I think it's ready to be reviewed by the maintainer. Please open a bugzilla PR for that.

Though I did not test this patch yet, I don't think it works. Please note that this port already has python flavors. Breaking the flavors is unacceptable.

Seems that this revision is not needed for the project I supposed to work on it. And I totally forgot that python is a flavor too.
Closing it. Sorry for the noise !