databases/py-sqlalchemy{14,20}: Add FLAVORS Adding FLAVORS Approved by: 0mp (mentor)
Details
Details
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Do I understand correctly that SQLITE is always enabled? Is that what we want?
Also, I think we might need a -sqllite flavor as well for completeness (which would be the same as the default flavor unfortunately). That's something to be discussed with the maintainer, however.
Otherwise, the patch looks OK. I think it's ready to be reviewed by the maintainer. Please open a bugzilla PR for that.
Comment Actions
Though I did not test this patch yet, I don't think it works. Please note that this port already has python flavors. Breaking the flavors is unacceptable.
Comment Actions
Seems that this revision is not needed for the project I supposed to work on it. And I totally forgot that python is a flavor too.
Closing it. Sorry for the noise !