Page MenuHomeFreeBSD

nextboot: Smarter warning about deleting nextboot
ClosedPublic

Authored by imp on Sat, Jan 11, 5:45 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jan 23, 1:45 AM
Unknown Object (File)
Fri, Jan 17, 8:35 AM
Unknown Object (File)
Thu, Jan 16, 12:21 PM
Unknown Object (File)
Thu, Jan 16, 8:10 AM
Unknown Object (File)
Thu, Jan 16, 3:08 AM
Unknown Object (File)
Tue, Jan 14, 9:12 PM
Unknown Object (File)
Sun, Jan 12, 6:18 PM
Subscribers

Details

Summary

Read only filesystems always error when trying to remove something
with EROFS. However, that's true even if the file isn't there. The
code assumed it would always get a ENOENT if the file wasn't there,
but produced a gross message on read only systems. This message was
harmless, but annoying. Instead, stat the file first and return if
it's already not there.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Sat, Jan 11, 5:45 AM
imp created this revision.
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Jan 14, 5:54 PM
This revision was automatically updated to reflect the committed changes.