Differential D4833

add safety belt check for boot1.efi file size
ClosedPublic
Actions

Authored by emaste on Jan 8 2016, 2:25 PM.

Details

Reviewers

smh

Commits

rS293425: Add safety belt for boot1.efi file size

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste updated this revision to Diff 12045.Jan 8 2016, 2:25 PM

emaste retitled this revision from to add safety belt check for boot1.efi file size.

emaste updated this object.

emaste edited the test plan for this revision. (Show Details)

emaste added a reviewer: smh.

emaste added a subscriber: smh.

Apart from the default for BOOT1_MAXSIZE this looks good and I've confirmed worked as expected locally, so nice one :)

sys/boot/efi/boot1/Makefile
82 ↗	(On Diff #12045)	This should really match BOOT1_SIZE from generate-fat.sh which is currently 128k not 64k

use same style of size check as boot2
update default max size after rS279533

smh added inline comments.Jan 8 2016, 4:08 PM

sys/boot/efi/boot1/Makefile
86 ↗	(On Diff #12051)	I would prefer to see something along the lines of: XX additional bytes required for boot1.efi (generate-fat.sh required?)

improve error message when boot1.efi is too large

smh accepted this revision.Jan 8 2016, 4:25 PM

smh edited edge metadata.

This revision is now accepted and ready to land.Jan 8 2016, 4:25 PM

Closed by commit rS293425: Add safety belt for boot1.efi file size (authored by emaste). · Explain WhyJan 8 2016, 4:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

boot/

efi/

boot1/

Makefile

7 lines

generate-fat.sh

11 lines

Diff 12053

View Options

head/sys/boot/efi/boot1/Makefile