Page MenuHomeFreeBSD

committers-guide: increase subject length limit to 67 characters
Needs ReviewPublic

Authored by emaste on Sun, Dec 29, 4:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 12, 4:34 AM
Unknown Object (File)
Sat, Jan 11, 6:02 AM
Unknown Object (File)
Fri, Jan 10, 12:06 PM
Unknown Object (File)
Thu, Jan 9, 9:33 AM
Unknown Object (File)
Wed, Jan 8, 8:43 PM
Unknown Object (File)
Wed, Jan 8, 8:01 PM
Unknown Object (File)
Sun, Dec 29, 6:22 PM
Subscribers

Details

Reviewers
None
Group Reviewers
srcmgr
Summary
I originally suggested a 63-character limit "so that git log --oneline
avoids wrapping".  Short hashes in the tree are typically 12 characters.
With a space between the hash and the subject should result in a limit
of 67 characters.  I think I arrived at 63 by subtracting git's typical
4-space indentation, but that's not applicable to `git log --oneline`.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

emaste created this revision.

btw, I got this script. Named wrap74, it would wrap lines to 74 chars. And you can have several symlinks/hardlinks for it, with different names, e.g. wrap79, wrap64.

#!/usr/local/bin/python

import fileinput
import textwrap
import os
import re

len = int(re.search('[0-9]+$', os.path.basename(__file__)).group())

all = ''
for line in fileinput.input():
        if (line == '\n'):
                print(textwrap.fill(all, len))
                print()
                all = ''
        else:
                all += line

print(textwrap.fill(all, len))