Differential D4812

net/ntp: Fix untracked gettext dependency & lots more
ClosedPublic
Actions

Authored by koobs on Jan 7 2016, 8:32 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Feb 5, 2:48 AM

	Unknown Object (File)
	Jan 10 2026, 2:53 AM

	Unknown Object (File)
	Dec 30 2025, 5:24 PM

	Unknown Object (File)
	Dec 29 2025, 12:11 PM

	Unknown Object (File)
	Nov 15 2025, 5:56 PM

	Unknown Object (File)
	Oct 30 2025, 2:44 PM

	Unknown Object (File)
	Oct 30 2025, 2:32 PM

	Unknown Object (File)
	Oct 30 2025, 2:19 PM

View All 88 Files

Subscribers

None

Details

Reviewers

Commits

rP405440: net/ntp-devel: Fix untracked gettext dependency & lots more

Summary

Commit log:

net/ntp: Fix untracked gettext dependency & lots more

ntp links against gettext (libintl) if it is installed on the system:

- Add an NLS OPTION to explicitly enable, disable and track libintl dependency
- Add DEBUG and THREADS OPTIONS. Keep the latter enabled by OPTIONS_DEFAULT to  
  preserve compatibility with existing behaviour.
- Explicitly pass OpenSSL include / library dir paths to configure
- Unsilence install command
- Enable verbose building (--disable-silent-rules)
- Use TOUCH variable instead of hardcoded command
- Add TEST_TARGET to enable test suite
- Patch sntp tests to ensure they link correctly to threading library
- Pet portlint (*_DEPENDS order, group USE{S} sections, sort OPTIONS)

Approved by:	cy (maintainer)
DiffRev:	D<ID>

Test Plan

portlint: OK (several warns, unrelated to changes)
porttest: OK (poudriere, 93i386, 102amd64, 11amd64, with/without NLS)
unittest: OK (PASS)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

koobs updated this revision to Diff 11987.Jan 7 2016, 8:32 AM

koobs retitled this revision from to net/ntp: Fix untracked gettext dependency & lots more.

koobs updated this object.

koobs edited the test plan for this revision. (Show Details)

koobs added a reviewer: cy.

koobs updated this object.Jan 7 2016, 8:35 AM

koobs edited the test plan for this revision. (Show Details)

koobs updated this object.

koobs updated this object.

Looks good.

Don't forget to also apply the patch to net/ntp-devel.

Thanks for the patch.

This revision is now accepted and ready to land.Jan 7 2016, 9:11 AM

Closed by commit rP405440: net/ntp-devel: Fix untracked gettext dependency & lots more (authored by koobs). · Explain WhyJan 7 2016, 2:16 PM

This revision was automatically updated to reflect the committed changes.

koobs mentioned this in rP405439: net/ntp: Fix untracked gettext dependency & lots more.

koobs mentioned this in rP405440: net/ntp-devel: Fix untracked gettext dependency & lots more.

koobs mentioned this in rP405466: MFH: r405439.Jan 7 2016, 4:15 PM

koobs mentioned this in rP405468: MFH: r405440.

Revision Contents
Changeset List

Path

Size

head/

net/

ntp-devel/

42 lines

1 line

Diff 11997

head/net/ntp-devel/Makefile

Loading...

head/net/ntp-devel/pkg-plist

Loading...