Page MenuHomeFreeBSD
Differential D4768

iwn: reduce code duplication in iwn_read_firmware()
ClosedPublic
Actions

Authored by avos on Jan 3 2016, 10:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 23, 8:33 AM
Unknown Object (File)
Mon, Mar 23, 7:28 AM
Unknown Object (File)
Sun, Mar 22, 1:49 AM
Unknown Object (File)
Sun, Mar 22, 1:49 AM
Unknown Object (File)
Sat, Mar 21, 7:28 AM
Unknown Object (File)
Fri, Mar 20, 5:55 PM
Unknown Object (File)
Fri, Mar 20, 3:30 AM
Unknown Object (File)
Thu, Mar 5, 12:10 PM
View All Files
Subscribers
imp

Details

Reviewers
adrian
Commits
rS293179: iwn: reduce code duplication in iwn_read_firmware()
Summary
  • Separate 'firmware_put(sc->fw_fp, FIRMWARE_UNLOAD); sc->fw_fp = NULL;' as iwn_unload_firmware().
  • Move error handling to the end of iwn_read_firmware().

No functional changes.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avos updated this revision to Diff 11889.Jan 3 2016, 10:05 PM
avos retitled this revision from to iwn: reduce code duplication in iwn_read_firmware().
avos updated this object.
avos edited the test plan for this revision. (Show Details)
avos added a reviewer: adrian.
avos set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJan 3 2016, 10:05 PM
adrian accepted this revision.Jan 4 2016, 4:10 AM
adrian edited edge metadata.
This revision is now accepted and ready to land.Jan 4 2016, 4:10 AM
Closed by commit rS293179: iwn: reduce code duplication in iwn_read_firmware() (authored by avos). · Explain WhyJan 4 2016, 9:11 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
dev/
iwn/
28 lines

Diff 11923

View Options

head/sys/dev/iwn/if_iwn.c

Loading...