Page MenuHomeFreeBSD

- Fix for py-mock
ClosedPublic

Authored by miwi on Dec 25 2015, 3:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 18, 4:29 PM
Unknown Object (File)
Wed, Mar 18, 12:55 PM
Unknown Object (File)
Sat, Mar 14, 3:34 PM
Unknown Object (File)
Thu, Mar 12, 12:18 PM
Unknown Object (File)
Wed, Mar 11, 4:39 PM
Unknown Object (File)
Feb 27 2026, 12:53 AM
Unknown Object (File)
Jan 30 2026, 5:55 PM
Unknown Object (File)
Jan 29 2026, 2:12 PM
Subscribers
None

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

miwi updated this revision to Diff 11679.
miwi retitled this revision from to - Fix for py-mock.
miwi updated this object.
miwi edited the test plan for this revision. (Show Details)
  • Add missing port

The new port looks good.

devel/py-mock/Makefile
18 ↗(On Diff #11680)

shouldn't it be depending on the version of python (not sure, i don't know how pbr works) ?
something like:

Index: devel/py-mock/Makefile
===================================================================
--- devel/py-mock/Makefile      (revision 404428)
+++ devel/py-mock/Makefile      (working copy)
@@ -23,4 +23,10 @@
 
 TESTS_RUN_DEPENDS=     ${PYTHON_PKGNAMEPREFIX}tox>0:${PORTSDIR}/devel/py-tox
 
-.include <bsd.port.mk>
+.include <bsd.port.pre.mk>
+
+.if ${PYTHON_REL} < 3300
+RUN_DEPENDS+=  ${PYTHON_PKGNAMEPREFIX}funcsigs>=0:${PORTSDIR}/devel/py-funcsigs
+.endif
+
+.include <bsd.port.post.mk>
koobs requested changes to this revision.Dec 25 2015, 3:44 PM
koobs edited edge metadata.
koobs added inline comments.
devel/py-funcsigs/Makefile
18 ↗(On Diff #11680)
do-test:
    @cd ${WRKSRC} && ${PYTHON_CMD} ${PYDISTUTILS_SETUP} test

Should just work here given authors have nicely set test_suite in setup.py

devel/py-mock/Makefile
16 ↗(On Diff #11680)

Even though python.mk implicitly adds setuptools to BUILD/RUN depends, this may not be the case forever.

Upstream explicitly states they require setuptools at setup (BUILD) time, so add that here

20–21 ↗(On Diff #11680)

Remove TESTS option, conditionals, and convert test bits to use the new test framework

This revision now requires changes to proceed.Dec 25 2015, 3:44 PM
miwi edited edge metadata.
miwi edited edge metadata.
  • Add explicit setuptools
  • Add py-six dependency

Remove duplicate funcsigs

koobs requested changes to this revision.Dec 25 2015, 4:22 PM
koobs edited edge metadata.
koobs added inline comments.
devel/py-mock/Makefile
24 ↗(On Diff #11684)

Leftover from TESTS option.

Should be TEST_DEPENDS, and moved up to *_DEPENDS section

This revision now requires changes to proceed.Dec 25 2015, 4:22 PM
miwi edited edge metadata.

remove test left overs, etc .

koobs edited edge metadata.
This revision is now accepted and ready to land.Dec 25 2015, 4:26 PM
This revision was automatically updated to reflect the committed changes.