Page MenuHomeFreeBSD
Differential D47041

uncompress: Avoid reading an extra byte
ClosedPublic
Actions

Authored by imp on Thu, Oct 10, 5:02 PM.

Details

Reviewers
emaste
Commits
rG818c7b769a4f: uncompress: Avoid reading an extra byte
Summary

When reading the next code in a stream, avoid reading an extra byte if
we're going to throw it away. When there's no more bits to extract from
the stream, bits will be 0 and we'll mask the read byte with 0 anyway.
At worst, this will avoid reading one past the end of gbuf array (which
is not possible in well formed streams).

PR: 127912

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Thu, Oct 10, 5:02 PM
imp created this revision.
Harbormaster completed remote builds in B59887: Diff 144599.Thu, Oct 10, 5:02 PM
emaste accepted this revision.Thu, Oct 10, 5:17 PM
This revision is now accepted and ready to land.Thu, Oct 10, 5:17 PM
Closed by commit rG818c7b769a4f: uncompress: Avoid reading an extra byte (authored by David Jones <drj@ravenbrook.com>, committed by imp). · Explain WhyFri, Oct 11, 3:56 PM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG818c7b769a4f: uncompress: Avoid reading an extra byte.

Revision Contents
Changeset List

PathSize
usr.bin/
compress/
3 lines

Diff 144652

View Options

usr.bin/compress/zopen.c

Loading...